From 62a6f204fdcf9913aa5b7c7fafd7ea593de78a6b Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Wed, 28 Dec 2022 20:36:33 +0000
Subject: [PATCH] Bug 32535: Exclude flags from BorrowerUnwantedField system
 preference

The system preference BorrowerUnwantedField includes a checkbox
for "System permissions (flags)." Checking it has no apparent effect;
one is still able to edit patron permissions with the box checked.
This patch excludes the field from the selectable fields.

To test:
* Search for the BorrowerUnwantedField system prefernce
* Verify that you can check/uncheck System permissions (flags)
* Verify it doesn't have any effect, as permissions are not set
  from the patron edit form, but separately
* Apply patch
* Verify you no longer can check/uncheck the field in the
  system preference

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
---
 .../prog/en/modules/admin/preferences/patrons.pref              | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
index 0edf57f6d9..f2ac0ce328 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
@@ -237,7 +237,7 @@ Patrons:
          - pref: BorrowerUnwantedField
            type: modalselect
            source: borrowers
-           exclusions: branchcode|categorycode
+           exclusions: branchcode|categorycode|flags
      -
          - "Borrowers can have the following titles:"
          - pref: BorrowersTitles
-- 
2.30.2