Attachment 145012 Details for Bug 32523 – Bug 32523: Links to missing fields in MARC editor error

[patch] Bug 32523: Links to missing fields in MARC editor error

Bug-32523-Links-to-missing-fields-in-MARC-editor-e.patch (text/plain), 1.86 KB, created by Jan Kissig on 2023-01-04 13:11:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Kissig

Created: 2023-01-04 13:11:06 UTC

Size: 1.86 KB

patch

obsolete

>From 54e6ed2514824914b666f4588d15c585e10fff10 Mon Sep 17 00:00:00 2001
>From: Jan Kissig <jkissig@th-wildau.de>
>Date: Wed, 4 Jan 2023 14:04:28 +0100
>Subject: [PATCH] Bug 32523: Links to missing fields in MARC editor error
>
>This bug appears after switching to the new staff interface design (from 22.05 to 22.11).
>When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field.
>This patch fixes that error.
>
>Test plan:
>1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=
>2) click Save
>3) Error dialog appears, informing about missing input in mandatory fields.
>4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible.
>5) In the error dialog click on a "Go to field" which points f.e. to section 9
>6) The selected / active tab will switch to section 9 and will not focus on the selected field
>7) apply patch
>8) repeat step 1) to 6)
>---
> .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt      | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 5d664a3a99..35147c3dbc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -177,7 +177,7 @@
>             e.preventDefault();
>             var tab = $(this).data("tab");
>             var field = $(this).data("field");
>-            var tablink = $("a[data-tabid='" + tab + "']" );
>+            var tablink = $("a[data-tabid='" + tab + "']" ).get(0).hash;
>             selectTab( tablink );
>             window.scrollTo( 0, getScrollto( field, "toolbar" ) );
>         });
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32523: 144829 | 144976 | 145002 | 145012 | 145013 | 145039 | 146151