From de105a2f928bf7a6d7e03e164efd0511dc2b5508 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 18 Jan 2023 19:53:54 +0000 Subject: [PATCH] Bug 15869: (QA follow-up) Don't pass placeholder framework '_USE_ORIG' This param in the dropdown is meant to signify no change, distinct from "" when means to set to default. In rebasing this condition was lost, this patch restores undef of the variable to avoid setting framework to an invalid value To test: 1 - Stage a record with a match (export and import a record) 2 - Attempt to import and overlay with option 'When replacing records use this framework:' 'Keep original framework' 3 - It fails, logs note 'value too long for field frameworkcode' 4 - Apply this patch 5 - Try again, it succeeds - framework is not changed --- tools/manage-marc-import.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/manage-marc-import.pl b/tools/manage-marc-import.pl index af94ab2a16..e48b479029 100755 --- a/tools/manage-marc-import.pl +++ b/tools/manage-marc-import.pl @@ -90,6 +90,7 @@ if ($op eq "") { } elsif ($op eq "commit-batch") { my $frameworkcode = $input->param('framework'); my $overlay_framework = $input->param('overlay_framework'); + $overlay_framework = undef if $overlay_framework = '_USE_ORIG'; try { my $job_id = Koha::BackgroundJob::MARCImportCommitBatch->new->enqueue( { -- 2.30.2