From 458ac33752c923942576c715391831d922601522 Mon Sep 17 00:00:00 2001 From: Kyle Hall Date: Thu, 5 Jan 2023 11:35:42 -0500 Subject: [PATCH] Bug 32573: Send ACK message to RabbitMQ before handling the job Content-Type: text/plain; charset=utf-8 Splitting off this functionality from bug 32558. In summary, we should be sending back ACK messages as soon as we've successfully processed ( e.g. read and decoded the data ) of a frame. Only then should we process it. Test plan: 1) Apply this patch 2) Launch background_jobs_worker.pl 3) Note no changes in background job processing Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy --- misc/background_jobs_worker.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/background_jobs_worker.pl b/misc/background_jobs_worker.pl index a9eda51681..8a379d60ea 100755 --- a/misc/background_jobs_worker.pl +++ b/misc/background_jobs_worker.pl @@ -100,8 +100,8 @@ while (1) { # It could work in a first step, but then we will want to handle job that will be created from the message received my $job = Koha::BackgroundJobs->find($args->{job_id}); + $conn->ack( { frame => $frame } ); # Acknowledge the message was received process_job( $job, $args ); - $conn->ack( { frame => $frame } ); # FIXME depending on success? } else { my $jobs = Koha::BackgroundJobs->search({ status => 'new', queue => \@queues }); -- 2.30.2