Bugzilla – Attachment 145621 Details for
Bug 30979
Add ability for OPAC users to checkout to themselves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31699: (follow-up) Protect against unauthorized redirects
Bug-31699-follow-up-Protect-against-unauthorized-r.patch (text/plain), 1.56 KB, created by
Martin Renvoize
on 2023-01-24 15:30:26 UTC
(
hide
)
Description:
Bug 31699: (follow-up) Protect against unauthorized redirects
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2023-01-24 15:30:26 UTC
Size:
1.56 KB
patch
obsolete
>From 885384b7de82cf729d8687c144bf95fe1cbcd9e2 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 9 Nov 2022 08:27:44 +0000 >Subject: [PATCH] Bug 31699: (follow-up) Protect against unauthorized redirects > >--- > koha-tmpl/opac-tmpl/bootstrap/js/global.js | 2 +- > opac/opac-user.pl | 4 +++- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/global.js b/koha-tmpl/opac-tmpl/bootstrap/js/global.js >index 27fe084755e..ce5d4f64b6a 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/global.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/global.js >@@ -228,7 +228,7 @@ $(document).ready(function(){ > var button = $(this); > var context = button.data('return'); > if ( context ) { >- $('#modalAuth').append('<input type="hidden" name="return" value="'+window.location+'" />'); >+ $('#modalAuth').append('<input type="hidden" name="return" value="'+window.location.pathname+window.location.search+'" />'); > } > $("#loginModal").modal("show"); > }); >diff --git a/opac/opac-user.pl b/opac/opac-user.pl >index 1b2aa815d29..a02e7f16acd 100755 >--- a/opac/opac-user.pl >+++ b/opac/opac-user.pl >@@ -428,8 +428,10 @@ if ($search_query) { > # back to the page we triggered the login from > my $return = $query->param('return'); > if ( $return ) { >+ my $uri = C4::Context->preference('OPACBaseURL'); >+ $uri .= $return; > print $query->redirect( >- -uri => $return, >+ -uri => $uri, > -cookie => $cookie, > ); > } >-- >2.39.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30979
:
139131
|
139132
|
139133
|
139134
|
141274
|
141275
|
141276
|
141277
|
141278
|
141279
|
141300
|
145264
|
145265
|
145266
|
145267
|
145268
|
145277
|
145280
|
145281
|
145282
|
145283
|
145284
|
145285
|
145620
|
145621
|
145622
|
145623
|
145624
|
145625
|
145626
|
145627
|
145628
|
145629
|
145630
|
150867
|
150868
|
150869
|
150870
|
150871
|
150872
|
150873
|
150874
|
150875
|
150876
|
150877
|
150878
|
150879
|
150880
|
150881
|
150882
|
150883
|
150884
|
150885
|
150886
|
150887
|
150888
|
150889
|
150967
|
150968
|
150969
|
150970
|
150971
|
150972
|
150973
|
150974
|
151254
|
151255
|
151256
|
151257
|
151258
|
151259
|
151260
|
151261
|
151358
|
151359
|
151360
|
151361
|
151362
|
151363
|
151364
|
151365
|
151368
|
151369
|
151370
|
151371
|
151372
|
151373
|
151374
|
151375
|
151376
|
152789
|
152790
|
152791
|
152792
|
152793
|
152794
|
152795
|
152796
|
152797
|
153459
|
153460
|
153461
|
153462
|
153463
|
153464
|
153465
|
153466
|
153467
|
153500
|
153501
|
153502
|
153503