Bugzilla – Attachment 145718 Details for
Bug 31576
[21.11] Cannot place hold even when AllowHoldPolicyOverride should allow it
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31576: Cannot place hold even when AllowHoldPolicyOverride should allow it
Bug-31576-Cannot-place-hold-even-when-AllowHoldPol.patch (text/plain), 2.13 KB, created by
Marcel de Rooy
on 2023-01-27 08:54:24 UTC
(
hide
)
Description:
Bug 31576: Cannot place hold even when AllowHoldPolicyOverride should allow it
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-01-27 08:54:24 UTC
Size:
2.13 KB
patch
obsolete
>From 69fdfef66ce0c86f0f8b480cb1712f363d141543 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Fri, 16 Sep 2022 10:57:53 -0400 >Subject: [PATCH] Bug 31576: Cannot place hold even when > AllowHoldPolicyOverride should allow it >Content-Type: text/plain; charset=utf-8 > >This bug appears in Koha 21.11 only ( behavior changes to bug 31575 with 22.05 and later ). If only some item holds can be forced, but others cannot ( because they have to pickup locations ), the place holds button remains disabled even though the hold can be placed. > >Test Plan: >1) Set one circ rule to allow 0 holds >2) For Library A, set "Hold pickup library match" to "item's hold group" >3) Enable AllowHoldPolicyOverride >4) Set ReservesControlBranch to "item's home branch" >5) Create a record with an item for Library A, one for Library B, and one for Library C > This should create a scenario where A's item cannot be held, and B and C's items must be overridden >6) Note you cannot place the hold because the button is disabled. >7) Apply this patch >8) Restart all the things! >9) Reload the page, the place hold button should now be enabled! > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Only checked the code, looks good to me. >--- > reserve/request.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 03dc8ab6fa..f6d99fc593 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -659,7 +659,7 @@ if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold ) > > # While we can't override an alreay held item, we should be able to override the others > # Unless all items are already held >- if ( $num_override > 0 && ($num_override + $num_alreadyheld) == scalar( @{ $biblioitem->{itemloop} } ) ) { >+ if ( $num_override > 0 && $num_alreadyheld < scalar @{ $biblioitem->{itemloop} } ) { > # That is, if all items require an override > $template->param( override_required => 1 ); > } elsif ( $num_items_available == 0 ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31576
:
140711
|
140738
| 145718