Bugzilla – Attachment 145725 Details for
Bug 27424
One should be able to assign an SMTP server as the default
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27424: (QA follow-up) Add confirmation if (un)checking the default smtp server checkbox
Bug-27424-QA-follow-up-Add-confirmation-if-uncheck.patch (text/plain), 2.95 KB, created by
Kyle M Hall
on 2023-01-27 12:00:03 UTC
(
hide
)
Description:
Bug 27424: (QA follow-up) Add confirmation if (un)checking the default smtp server checkbox
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2023-01-27 12:00:03 UTC
Size:
2.95 KB
patch
obsolete
>From 4aa23840e12dbe10b9fd86ea55f82d2585224316 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Fri, 27 Jan 2023 06:56:42 -0500 >Subject: [PATCH] Bug 27424: (QA follow-up) Add confirmation if (un)checking > the default smtp server checkbox > >--- > .../prog/en/modules/admin/smtp_servers.tt | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >index 810e72253c..c48d1bdc00 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >@@ -310,6 +310,24 @@ > </div> <!-- /.modal-dialog --> > </div> <!-- #delete_confirm_modal --> > >+ <div id="default_confirm_modal" class="modal" tabindex="-1" role="dialog" aria-labelledby="default_confirm_modal_label" aria-hidden="true"> >+ <div class="modal-dialog"> >+ <div class="modal-content"> >+ <div class="modal-header"> >+ <button type="button" class="default_confirm_modal_no closebtn" data-dismiss="modal" aria-hidden="true">Ã</button> >+ <h3 id="default_confirm_modal_label">Set default server</h3> >+ </div> >+ <div class="modal-body"> >+ <div id="default_confirm_dialog">Are you sure you want to change the default SMTP server?</div> >+ </div> >+ <div class="modal-footer"> >+ <a id="default_confirm_dialog" href="#" class="btn btn-default default_confirm_modal_yes" id="default_confirm_modal_button" role="button" data-toggle="modal">Yes</a> >+ <button class="btn btn-link default_confirm_modal_no" data-dismiss="modal" aria-hidden="true">No</button> >+ </div> >+ </div> <!-- /.modal-content --> >+ </div> <!-- /.modal-dialog --> >+ </div> <!-- #default_confirm_modal --> >+ > </main> > </div> <!-- /.col-sm-10.col-sm-push-2 --> > >@@ -441,6 +459,17 @@ > $("#delete_confirm_modal_button").data('smtp-server-name', smtp_server_name); > }); > >+ $('#smtp_default').on( "click", function () { >+ $("#default_confirm_modal").show(); >+ }); >+ $('.default_confirm_modal_yes').on( "click", function () { >+ $("#default_confirm_modal").hide(); >+ }); >+ $('.default_confirm_modal_no').on( "click", function () { >+ $("#smtp_default").prop('checked', !$("#smtp_default").prop('checked') ); >+ $("#default_confirm_modal").hide(); >+ }); >+ > $("#delete_confirm_modal_button").on( "click", function () { > > var smtp_server_id = $(this).data('smtp-server-id'); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27424
:
129673
|
129674
|
129675
|
129814
|
130168
|
130169
|
130170
|
130171
|
130172
|
130300
|
130301
|
130302
|
130303
|
130304
|
145697
|
145698
|
145699
|
145700
|
145701
|
145702
|
145705
|
145723
|
145724
| 145725 |
152192