Bugzilla – Attachment 145762 Details for
Bug 29021
Automatic renewal due to RenewAccruingItemWhenPaid should not be considered Seen
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29021: (QA follow-up) Fix for new parameter, add unit test
Bug-29021-QA-follow-up-Fix-for-new-parameter-add-u.patch (text/plain), 1.50 KB, created by
Kyle M Hall
on 2023-01-27 16:59:55 UTC
(
hide
)
Description:
Bug 29021: (QA follow-up) Fix for new parameter, add unit test
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2023-01-27 16:59:55 UTC
Size:
1.50 KB
patch
obsolete
>From 819b442311d31d6defcb29521a89f365a5ec5dc7 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Fri, 27 Jan 2023 11:58:45 -0500 >Subject: [PATCH] Bug 29021: (QA follow-up) Fix for new parameter, add unit > test > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/Account/Line.pm | 1 + > t/db_dependent/Koha/Account/Line.t | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm >index e7e63adbfa..6ab6120a1a 100644 >--- a/Koha/Account/Line.pm >+++ b/Koha/Account/Line.pm >@@ -1035,6 +1035,7 @@ sub renew_item { > $self->{branchcode}, > undef, > undef, >+ undef, > 0 > ); > return { >diff --git a/t/db_dependent/Koha/Account/Line.t b/t/db_dependent/Koha/Account/Line.t >index 9d29dad3e3..c7c7b34213 100755 >--- a/t/db_dependent/Koha/Account/Line.t >+++ b/t/db_dependent/Koha/Account/Line.t >@@ -568,10 +568,10 @@ subtest 'Renewal related tests' => sub { > ); > my $called = 0; > my $module = Test::MockModule->new('C4::Circulation'); >- $module->mock('AddRenewal', sub { $called = 1; }); > $module->mock('CanBookBeRenewed', sub { return 1; }); > $line->renew_item; >- is( $called, 1, 'Attempt to renew succeeds when conditions are met' ); >+ my $r = Koha::Checkouts::Renewals->find({ checkout_id => $issue->id }); >+ is( $r->seen, 0, "RenewAccruingItemWhenPaid triggers an unseen renewal" ); > > $schema->storage->txn_rollback; > }; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29021
:
134897
|
144503
|
145761
| 145762 |
145799