From b02637e513ac6bc1e4a0c329b64860893cc09384 Mon Sep 17 00:00:00 2001 From: David Nind Date: Sun, 4 Dec 2022 01:33:32 +0000 Subject: [PATCH] Bug 32312: Add missing column descriptions to the statistics table This adds missing descriptions to the existing statistics database columns. It also improves some existing descriptions. 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that there are no descriptions for: - statistics.other - statistics.location - statistics.ccode - statistics.categorycode 5. Note that: - the description for statistics.type is 'Type' - the description for statistics.itemtype is 'Item type' 6. Apply the patch. 7. Restart all the things (restart_all). 8. Reload the page. 9. Note that: . there are now descriptions for the columns in step 4 . the description for statistics.type is now 'Transaction type' (to more clearly indicate what it contains) . the description for statistics.itemtype is now 'Koha item type' (consistent with other tables where this is used, such as items) 10. Sign off :D Signed-off-by: David Nind Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize --- Koha/Database/Columns.pm | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/Koha/Database/Columns.pm b/Koha/Database/Columns.pm index 0fe0efc181e..626eccf33f0 100644 --- a/Koha/Database/Columns.pm +++ b/Koha/Database/Columns.pm @@ -173,14 +173,17 @@ sub columns { "new_status" => __("New status"), }, statistics => { - "datetime" => __("Statistics date and time"), - "branch" => __("Library"), - "value" => __("Value"), - "type" => __("Type"), - "other" => __(""), - "itemnumber" => __("Item number"), - "itemtype" => __("Itemtype"), - "borrowernumber" => __("Borrower number"), + "datetime" => __("Statistics date and time"), + "branch" => __("Library"), + "value" => __("Value"), + "type" => __("Transaction type"), + "other" => __("SIP mode"), + "itemnumber" => __("Item number"), + "itemtype" => __("Koha item type"), + "location" => __("Shelving location"), + "borrowernumber" => __("Borrower number"), + "ccode" => __("Collection"), + "categorycode" => __("Patron category"), }, biblio => { "frameworkcode" => __("Framework code"), -- 2.39.1