From 1756ff55ecb4553b4cb33bb3e9c9dd2936464b6f Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Tue, 1 Nov 2022 09:21:57 +0200 Subject: [PATCH] Bug 24616: Do not save form if user press cancel If one starts to copy a notice but then cancels this when pop-up is displayed, changes are still saved. This patch fixes this. To test: 1. Copy notice to a library where it already exists 2. Press save and then cancel when pop-up is displayed => Form and changes are still saved 3. Apply this patch. 4. Repeat steps 1. and 2. => Form is no longer saved Sponsored-by: Koha-Suomi Oy Signed-off-by: ml-inlibro Signed-off-by: Katrin Fischer --- koha-tmpl/intranet-tmpl/prog/js/letter.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/letter.js b/koha-tmpl/intranet-tmpl/prog/js/letter.js index da044f5dd4..365878e7f2 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/letter.js +++ b/koha-tmpl/intranet-tmpl/prog/js/letter.js @@ -29,7 +29,7 @@ function checkCodes( new_lettercode, new_branchcode ){ } }); } - +//This has bug function confirmOverwrite( new_lettercode, new_branchcode ){ var letter_exists; $.ajax({ @@ -127,7 +127,7 @@ $(document).ready(function() { var new_lettercode = $("#code").val(); var new_branchcode = $("#branch").val(); var confirm = confirmOverwrite( new_lettercode, new_branchcode ); - if( confirm && confirm === false){ + if(confirm === false){ return false; } } -- 2.30.2