From d2a32a4b2e29849b67ec86da25d47c59c0f78f4a Mon Sep 17 00:00:00 2001 From: Andreas Roussos Date: Wed, 8 Feb 2023 15:07:52 +0100 Subject: [PATCH] Bug 32909: Load item type icons from the correct path When placing an item-level hold in the Staff interface, the table at the bottom of the screen (under the "Place a hold on a specific item" heading) should display the icon associated with the item type of each item in the 'Item type' column. This feature broke in v22.05.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Select 'Holds' on the left hand side, then pick a patron. The "Place a hold on ..." page should load. In the 'Item type' column of the table at the bottom of the screen notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*] [*] In non-Debian package installs, the 'href' property of the item type icon's tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, restart Plack and refresh the page. The item type icon should now be displayed correctly. KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect': the 'href' property of the tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg' --- reserve/request.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reserve/request.pl b/reserve/request.pl index e5faf1426a..0c37d6e4c1 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -70,7 +70,7 @@ my $pickup = $input->param('pickup'); my $itemtypes = { map { $_->itemtype => - { %{ $_->unblessed }, image_location => $_->image_location, notforloan => $_->notforloan } + { %{ $_->unblessed }, image_location => $_->image_location('intranet'), notforloan => $_->notforloan } } Koha::ItemTypes->search_with_localization->as_list }; -- 2.20.1