Bugzilla – Attachment 146462 Details for
Bug 31563
Numbers on claims tab not showing in translated templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31563: Make zero claims show correctly for translations
Bug-31563-Make-zero-claims-show-correctly-for-tran.patch (text/plain), 3.84 KB, created by
Katrin Fischer
on 2023-02-09 23:33:50 UTC
(
hide
)
Description:
Bug 31563: Make zero claims show correctly for translations
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-02-09 23:33:50 UTC
Size:
3.84 KB
patch
obsolete
>From ff8d90ce9e6bfdb26b6ce71cd839ca5f54c7a25c Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Fri, 10 Feb 2023 00:29:55 +0100 >Subject: [PATCH] Bug 31563: Make zero claims show correctly for translations > >A tag that only contains 0 is turned into an empty tag by >the translation scripts. This turns "Claims ( 0 0 )" into >"Claims ( )" in translated templates. > >To test: >* Install an additional language (fr-FR, es-ES) and activate > it in the system preferences >* Look at the checkouts and details tabs in any patron account > in the staff interface >* Verify the claims tab shows without the zeros as described above >* Apply the patch >* Update the translation so the templates are recreated with the change >* Verify that the 0 0 now show correctly. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 5 +++-- > .../intranet-tmpl/prog/en/modules/members/moremember.tt | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index a24fece83c..600202d025 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -871,10 +871,11 @@ > [% END %]) > </a> > [% ELSE %] >+ [% no_claims = 0 %] > <a href="#return-claims" id="return-claims-tab" aria-controls="return-claims" role="tab" data-toggle="tab"> > Claims >- (<span title="Resolved claims" class="label label-default" id="return-claims-count-resolved">0</span> >- <span title="Unresolved claims" class="label label-default" id="return-claims-count-unresolved">0</span>) >+ (<span title="Resolved claims" class="label label-default" id="return-claims-count-resolved">[% no_claims %]</span> >+ <span title="Unresolved claims" class="label label-default" id="return-claims-count-unresolved">[% no_claims %]</span>) > </a> > [% END %] > </li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index e37050d1af..10b57a94c2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -703,10 +703,11 @@ > [% END %]) > </a> > [% ELSE %] >+ [% no_claims = 0 %] > <a href="#return-claims" id="return-claims-tab" aria-controls="return-claims" role="tab" data-toggle="tab"> > Claims >- (<span title="Resolved claims" class="label label-default" id="return-claims-count-resolved">0</span> >- <span title="Unresolved claims" class="label label-default" id="return-claims-count-unresolved">0</span>) >+ (<span title="Resolved claims" class="label label-default" id="return-claims-count-resolved">[% no_claims %]</span> >+ <span title="Unresolved claims" class="label label-default" id="return-claims-count-unresolved">[% no_claims %]</span>) > </a> > [% END %] > </li> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31563
:
140631
|
146462
|
146518
|
147170
|
147223
|
147409