View | Details | Raw Unified | Return to bug 30642
Collapse All | Expand All

(-)a/C4/Circulation.pm (-3 / +5 lines)
Lines 3020-3026 sub CanBookBeRenewed { Link Here
3020
3020
3021
=head2 AddRenewal
3021
=head2 AddRenewal
3022
3022
3023
  &AddRenewal($borrowernumber, $itemnumber, $branch, [$datedue], [$lastreneweddate], [$seen]);
3023
  &AddRenewal($borrowernumber, $itemnumber, $branch, [$datedue], [$lastreneweddate], [$seen], [$automatic]);
3024
3024
3025
Renews a loan.
3025
Renews a loan.
3026
3026
Lines 3049-3054 C<$seen> is a boolean flag indicating if the item was seen or not during the ren Link Here
3049
informs the incrementing of the unseen_renewals column. If this flag is not supplied, we
3049
informs the incrementing of the unseen_renewals column. If this flag is not supplied, we
3050
fallback to a true value
3050
fallback to a true value
3051
3051
3052
C<$automatic> is a boolean flag indicating the renewal was triggered automatically and not by a person ( librarian or patron )
3053
3052
=cut
3054
=cut
3053
3055
3054
sub AddRenewal {
3056
sub AddRenewal {
Lines 3059-3064 sub AddRenewal { Link Here
3059
    my $lastreneweddate = shift || dt_from_string();
3061
    my $lastreneweddate = shift || dt_from_string();
3060
    my $skipfinecalc    = shift;
3062
    my $skipfinecalc    = shift;
3061
    my $seen            = shift;
3063
    my $seen            = shift;
3064
    my $automatic       = shift;
3062
3065
3063
    # Fallback on a 'seen' renewal
3066
    # Fallback on a 'seen' renewal
3064
    $seen = defined $seen && $seen == 0 ? 0 : 1;
3067
    $seen = defined $seen && $seen == 0 ? 0 : 1;
Lines 3068-3075 sub AddRenewal { Link Here
3068
    my $issue  = $item_object->checkout;
3071
    my $issue  = $item_object->checkout;
3069
    my $item_unblessed = $item_object->unblessed;
3072
    my $item_unblessed = $item_object->unblessed;
3070
3073
3071
    my ($package, $filename, $line) = caller;
3074
    my $renewal_type = $automatic ? "Automatic" : "Manual";
3072
    my $renewal_type = $filename =~ m/automatic_renewals.pl/ ? "Automatic" : "Manual";
3073
3075
3074
    my $dbh = C4::Context->dbh;
3076
    my $dbh = C4::Context->dbh;
3075
3077
(-)a/misc/cronjobs/automatic_renewals.pl (-1 / +1 lines)
Lines 180-186 while ( my $auto_renew = $auto_renews->next ) { Link Here
180
              $auto_renew->issue_id, $auto_renew->borrowernumber, $auto_renew->itemnumber, $confirm ? 'will' : 'would';
180
              $auto_renew->issue_id, $auto_renew->borrowernumber, $auto_renew->itemnumber, $confirm ? 'will' : 'would';
181
        }
181
        }
182
        if ($confirm){
182
        if ($confirm){
183
            my $date_due = AddRenewal( $auto_renew->borrowernumber, $auto_renew->itemnumber, $auto_renew->branchcode, undef, undef, undef, 0 );
183
            my $date_due = AddRenewal( $auto_renew->borrowernumber, $auto_renew->itemnumber, $auto_renew->branchcode, undef, undef, undef, 0, 1 );
184
            $auto_renew->auto_renew_error(undef)->store;
184
            $auto_renew->auto_renew_error(undef)->store;
185
        }
185
        }
186
        push @{ $report{ $auto_renew->borrowernumber } }, $auto_renew
186
        push @{ $report{ $auto_renew->borrowernumber } }, $auto_renew
(-)a/t/db_dependent/Circulation.t (-3 / +3 lines)
Lines 4614-4620 subtest 'AddRenewal and AddIssuingCharge tests' => sub { Link Here
4614
};
4614
};
4615
4615
4616
subtest 'AddRenewal() adds to renewals' => sub {
4616
subtest 'AddRenewal() adds to renewals' => sub {
4617
    plan tests => 4;
4617
    plan tests => 5;
4618
4618
4619
    my $library  = $builder->build_object({ class => 'Koha::Libraries' });
4619
    my $library  = $builder->build_object({ class => 'Koha::Libraries' });
4620
    my $patron   = $builder->build_object({
4620
    my $patron   = $builder->build_object({
Lines 4631-4637 subtest 'AddRenewal() adds to renewals' => sub { Link Here
4631
    is(ref($issue), 'Koha::Checkout', 'Issue added');
4631
    is(ref($issue), 'Koha::Checkout', 'Issue added');
4632
4632
4633
    # Renew item
4633
    # Renew item
4634
    my $duedate = AddRenewal( $patron->id, $item->id, $library->id );
4634
    my $duedate = AddRenewal( $patron->id, $item->id, $library->id, undef, undef, undef, undef, 1 );
4635
4635
4636
    ok( $duedate, "Renewal added" );
4636
    ok( $duedate, "Renewal added" );
4637
4637
Lines 4639-4644 subtest 'AddRenewal() adds to renewals' => sub { Link Here
4639
    is($renewals->count, 1, 'One renewal added');
4639
    is($renewals->count, 1, 'One renewal added');
4640
    my $THE_renewal = $renewals->next;
4640
    my $THE_renewal = $renewals->next;
4641
    is( $THE_renewal->renewer_id, C4::Context->userenv->{'number'}, 'Renewer recorded from context' );
4641
    is( $THE_renewal->renewer_id, C4::Context->userenv->{'number'}, 'Renewer recorded from context' );
4642
    is( $THE_renewal->renewal_type, 'Automatic', 'AddRenewal "automatic" parameter sets renewal type to "Automatic"');
4642
};
4643
};
4643
4644
4644
subtest 'ProcessOfflinePayment() tests' => sub {
4645
subtest 'ProcessOfflinePayment() tests' => sub {
4645
- 

Return to bug 30642