Attachment 146493 Details for Bug 32908 – Bug 32908: Load item type icons from the correct path

[patch] Bug 32908: Load item type icons from the correct path

Bug-32908-Load-item-type-icons-from-the-correct-pa.patch (text/plain), 3.27 KB, created by Martin Renvoize (ashimema) on 2023-02-10 16:33:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-02-10 16:33:20 UTC

Size: 3.27 KB

patch

obsolete

>From 9e17bf48d33e6f36eeb4339a5594e2d6023c04d6 Mon Sep 17 00:00:00 2001
>From: George Veranis <gveranis@dataly.gr>
>Date: Wed, 8 Feb 2023 13:21:39 +0100
>Subject: [PATCH] Bug 32908: Load item type icons from the correct path
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>In the Staff interface, the details page of a bibliographic
>record should display the icon associated with the item
>type of an item ('Item type' column in the 'Holdings' tab).
>
>This feature broke in v22.11.00 (for Debian package installs):
>instead of the item type icon you get the default 'broken
>image URL' image of your web browser.
>
>This patch fixes that.
>
>Test plan:
>
>1) (if needed) Configure the following System preferences:
>   - item-level_itypes => 'specific item'
>   - noItemTypeImages  => 'Show'
>
>2) (if needed) In Koha Administration > Item types, create
>   an item type and associate it with an icon
>
>3) (if needed) Create a test bibliographic record, and add
>   an item to it that has an item type with an icon
>
>4) Visit the bibliographic record's details page in the
>   Staff interface. Notice that in the 'Item type' column of
>   the 'Holdings' tab instead of seeing the icon associated
>   with the item type of each item you get the default
>   'broken image URL' image of your web browser [*].
>
>   [*] In non-Debian package installs, the 'href' property
>       of the item type icon's <img> tag should start with
>       '/opac-tmpl/bootstrap/itemtypeimg'
>
>5) Apply this patch, and refresh the page with CTRL-F5.
>   The item type icon should now be displayed correctly.
>
>   [*] KTD and Koha Sandboxes users: To verify the patch
>       has worked, you should right-click on the item type
>       icon and click 'Inspect: the 'href' property of the
>       <img> tag should now start with:
>       '/intranet-tmpl/prog/img/itemtypeimg'
>
>Signed-off-by: FrÃ©dÃ©ric Demians <f.demians@tamil.fr>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 58ca8e1a70..a5dc67707f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -405,8 +405,8 @@
>                     [% IF ( item_level_itypes ) %]
>                         <td class="itype">
>                             [% SET itemtype = item.itemtype %]
>-                            [% IF !noItemTypeImages && itemtype.image_location %]
>-                                <img src="[% itemtype.image_location | html %]" alt="[% itemtype.translated_description | html %]" title="[% itemtype.translated_description | html %]" />
>+                            [% IF !noItemTypeImages && itemtype.image_location('intranet') %]
>+                                <img src="[% itemtype.image_location('intranet') | html %]" alt="[% itemtype.translated_description | html %]" title="[% itemtype.translated_description | html %]" />
>                             [% END %]
>                             <span class="itypedesc itypetext">[% itemtype.translated_description | html %]</span>
>                         </td>
>-- 
>2.39.1

Actions: View | Diff | Splinter Review

Attachments on bug 32908: 146386 | 146387 | 146388 | 146393 | 146493