Bugzilla – Attachment 146689 Details for
Bug 32925
Display loading info when a form is submitted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32925: Rename isSubmitting with submitting
Bug-32925-Rename-isSubmitting-with-submitting.patch (text/plain), 2.56 KB, created by
Jonathan Druart
on 2023-02-15 13:17:50 UTC
(
hide
)
Description:
Bug 32925: Rename isSubmitting with submitting
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-02-15 13:17:50 UTC
Size:
2.56 KB
patch
obsolete
>From fad5f9e414d4ad5003be3aec565d5325d3d17105 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 15 Feb 2023 14:17:16 +0100 >Subject: [PATCH] Bug 32925: Rename isSubmitting with submitting > >Asking to do somthing, not asking if it's being done >--- > koha-tmpl/intranet-tmpl/prog/js/vue/fetch/http-client.js | 4 ++-- > koha-tmpl/intranet-tmpl/prog/js/vue/messages.js | 6 +++--- > koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/http-client.js b/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/http-client.js >index 1bbfa44c999..ce3f933a0b4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/http-client.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/http-client.js >@@ -1,4 +1,4 @@ >-import { setError, isSubmitting, submitted } from "../messages"; >+import { setError, submitting, submitted } from "../messages"; > > class HttpClient { > constructor(options = {}) { >@@ -16,7 +16,7 @@ class HttpClient { > mark_submitting = false, > ) { > let res, error; >- if ( mark_submitting) isSubmitting() >+ if ( mark_submitting) submitting() > await fetch(this._baseURL + endpoint, { > ...options, > headers: { ...this._headers, ...headers }, >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/messages.js b/koha-tmpl/intranet-tmpl/prog/js/vue/messages.js >index 7285f31a9fe..7b9d5f904e1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/messages.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/messages.js >@@ -22,10 +22,10 @@ export const removeMessages = function () { > const { removeMessages } = mainStore; > removeMessages(); > }; >-export const isSubmitting = function () { >+export const submitting = function () { > const mainStore = useMainStore(); >- const { isSubmitting } = mainStore; >- isSubmitting(); >+ const { submitting } = mainStore; >+ submitting(); > }; > export const submitted = function () { > const mainStore = useMainStore(); >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js b/koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js >index 54bfe099efd..58305dd4bb4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js >@@ -35,7 +35,7 @@ export const useMainStore = defineStore("main", { > } > this.displayed_already = true; > }, >- isSubmitting(){ >+ submitting(){ > this.is_submitting = true; > }, > submitted(){ >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32925
:
146428
|
146436
|
146469
|
146683
|
146684
|
146685
|
146686
|
146689
|
147045
|
147046
|
147047
|
147048
|
147049
|
147076
|
147077
|
147078
|
147079
|
147080
|
147324
|
147325
|
147326
|
147327
|
147328