From ef60267cb989a7411313be11510f630b3de030d2 Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Thu, 22 Nov 2012 10:48:08 +0100 Subject: [PATCH] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but remains) + fix a typo 'selelcted' > 'selected' Amended patch: - add use Modern::Perl; in reports/guided_reports.pl - remove a simple-quote string in guided_reports_start.tt Signed-off-by: Kyle M Hall --- .../prog/en/modules/reports/guided_reports_start.tt | 8 +++++--- reports/guided_reports.pl | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index 819cd0a..b2aacdb 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -67,7 +67,7 @@ $(document).ready(function(){ { 'bSearchable': false, 'aTargets': [3, 4] } ], 'oLanguage': { - 'sZeroRecords': _('No matching reports found') + 'sZeroRecords': _("No matching reports found") } })); @@ -280,7 +280,9 @@ canned reports and writing custom SQL reports.

Saved results Saved SQL   -   + [% IF ( CAN_user_reports_create_reports ) %] +   + [% END %] @@ -808,7 +810,7 @@ Sub report: [% ELSE %] -
  • +
  • [% END %] [% IF (usecache) %]
  • diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl index ed9aa6e..d920e09 100755 --- a/reports/guided_reports.pl +++ b/reports/guided_reports.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +use Modern::Perl; use CGI; use Text::CSV; use URI::Escape; -- 1.7.10.4