From 5ca8c4516b2d0f331b90f562b8091fba3188803b Mon Sep 17 00:00:00 2001 From: Julian Maurice <julian.maurice@biblibre.com> Date: Fri, 3 Feb 2023 11:58:52 +0100 Subject: [PATCH] Bug 32832: Fix cataloguing/value_builder/unimarc_field_120.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before --- cataloguing/value_builder/unimarc_field_120.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cataloguing/value_builder/unimarc_field_120.pl b/cataloguing/value_builder/unimarc_field_120.pl index 4c4d06139d..7e13a724c5 100755 --- a/cataloguing/value_builder/unimarc_field_120.pl +++ b/cataloguing/value_builder/unimarc_field_120.pl @@ -34,9 +34,10 @@ my ($dbh,$record,$tagslib,$field_number) = @_; my $function_name=$field_number; my $res=" <script> -function Clic$function_name(i) { - defaultvalue=document.getElementById(\"$field_number\").value; - newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_120.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_120\",'width=1200,height=750,toolbar=false,scrollbars=yes'); +function Clic$function_name(event) { + event.preventDefault(); + defaultvalue=document.getElementById(event.data.id).value; + newin=window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_120.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_120\",'width=1200,height=750,toolbar=false,scrollbars=yes'); } </script> -- 2.30.2