From 8fd34c56de3b45b737e27de4506fc44c4aa547bb Mon Sep 17 00:00:00 2001 From: Julian Maurice <julian.maurice@biblibre.com> Date: Fri, 3 Feb 2023 11:58:53 +0100 Subject: [PATCH] Bug 32845: Fix cataloguing/value_builder/unimarc_field_124c.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before --- cataloguing/value_builder/unimarc_field_124c.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cataloguing/value_builder/unimarc_field_124c.pl b/cataloguing/value_builder/unimarc_field_124c.pl index 3433ea9a93..571b6b62ca 100755 --- a/cataloguing/value_builder/unimarc_field_124c.pl +++ b/cataloguing/value_builder/unimarc_field_124c.pl @@ -32,9 +32,10 @@ my ($dbh,$record,$tagslib,$field_number) = @_; my $function_name= $field_number; my $res=" <script> -function Clic$function_name(i) { - defaultvalue=document.getElementById(\"$field_number\").value; - window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_124c.pl&index=\"+i+\"&result=\"+defaultvalue,\"unimarc_field_124c\",'width=1000,height=375,toolbar=false,scrollbars=yes'); +function Clic$function_name(event) { + event.preventDefault(); + defaultvalue=document.getElementById(event.data.id).value; + window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_124c.pl&index=\"+event.data.id+\"&result=\"+defaultvalue,\"unimarc_field_124c\",'width=1000,height=375,toolbar=false,scrollbars=yes'); } </script> -- 2.30.2