From 5cc84b169576cc425378db9ea64451a4fbb6362d Mon Sep 17 00:00:00 2001 From: Julian Maurice <julian.maurice@biblibre.com> Date: Fri, 3 Feb 2023 11:58:55 +0100 Subject: [PATCH] Bug 32875: Fix cataloguing/value_builder/unimarc_leader_authorities.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before --- cataloguing/value_builder/unimarc_leader_authorities.pl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/cataloguing/value_builder/unimarc_leader_authorities.pl b/cataloguing/value_builder/unimarc_leader_authorities.pl index 365a44ddbb..11b0a0b4db 100755 --- a/cataloguing/value_builder/unimarc_leader_authorities.pl +++ b/cataloguing/value_builder/unimarc_leader_authorities.pl @@ -30,15 +30,16 @@ sub plugin_javascript { my ( $dbh, $record, $tagslib, $field_number ) = @_; my $res = " <script type='text/javascript'> - function Clic$field_number(i) { + function Clic$field_number(event) { + event.preventDefault(); var defaultvalue; try { - defaultvalue = document.getElementById(i).value; + defaultvalue = document.getElementById(event.data.id).value; } catch(e) { - alert('error when getting '+i); + alert('error when getting '+event.data.id); return; } - window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_leader_authorities.pl&index=\"+i+\"&result=\"+defaultvalue,\"unimarc_field_000\",'width=1000,height=600,toolbar=false,scrollbars=yes'); + window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_leader_authorities.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"unimarc_field_000\",'width=1000,height=600,toolbar=false,scrollbars=yes'); } </script> "; -- 2.30.2