From a3e81ed827be56fbddea3ab94fbc1769fdb40f3c Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Sat, 18 Feb 2023 17:10:28 +0000
Subject: [PATCH] Bug 31450: (follow-up) Add hint about empty publication date

This patch adds a hint to the additional contents form when the
user is adding a news item, "News without a publication date will
not display."

This patch also makes to extra changes: Changing the grammatically
incorrect heading "Modify an additional content" to "Modify
additional content."

The patch also splits the expiration date hint into two separate
div.hint containers for better readability.

To test, apply the patch and add a new news item. You should see
the new hint under the publication date field.

Try adding an HTML customization. The hint should not appear.
---
 .../prog/en/modules/tools/additional-contents.tt  | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
index 30b0103a808..6e865411383 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
@@ -180,7 +180,7 @@
 
 [% BLOCK add_form %]
     [% IF additional_content %]
-        <h1>Modify an additional content</h1>
+        <h1>Modify additional content</h1>
     [% ELSE %]
         <h1>New additional content ([% IF category == 'news' %]News[% ELSIF category == 'pages' %]Pages[% ELSE %]HTML customizations[% END %])</h1>
     [% END %]
@@ -245,16 +245,23 @@
                     <label for="from">Publication date: </label>
                     <input id="from" type="text" name="published_on" size="15" value="[% additional_content.published_on | html %]" class="flatpickr" data-date_to="to" />
                     <div class="hint">[% INCLUDE 'date-format.inc' %]</div>
+                    [% IF ( category == 'news' ) %]
+                        <div class="hint">
+                            News without a publication date will not display
+                        </div>
+                    [% END %]
                 </li>
                 <li>
                     <label for="to">Expiration date: </label>
                     <input id="to" type="text" name="expirationdate" size="15" value="[% additional_content.expirationdate | html %]" class="flatpickr" />
                     <div class="hint">
                         [% INCLUDE 'date-format.inc' %]
-                        [% IF category == 'news' %]
-                            <br>News will still be accessible by direct URL if expired.
-                        [% END %]
                     </div>
+                    [% IF category == 'news' %]
+                        <div class="hint">
+                            News will still be accessible by direct URL if expired.
+                        </div>
+                    [% END %]
                 </li>
                 <li>
                     <label for="number">Appear in position: </label>
-- 
2.30.2