Bugzilla – Attachment 147369 Details for
Bug 32828
Fix cataloguing/value_builder/unimarc_field_115a.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32828: Fix cataloguing/value_builder/unimarc_field_115a.pl
Bug-32828-Fix-cataloguingvaluebuilderunimarcfield1.patch (text/plain), 1.77 KB, created by
Nick Clemens (kidclamp)
on 2023-02-24 16:59:25 UTC
(
hide
)
Description:
Bug 32828: Fix cataloguing/value_builder/unimarc_field_115a.pl
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2023-02-24 16:59:25 UTC
Size:
1.77 KB
patch
obsolete
>From 77f7d719e48a028e763bb7030442d67b668d1183 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 3 Feb 2023 11:58:52 +0100 >Subject: [PATCH] Bug 32828: Fix > cataloguing/value_builder/unimarc_field_115a.pl > >Use event parameter > >This is part of the refactoring happening in bug 30975 > >Test plan: >1. Verify that the plugin continues to work as before > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > cataloguing/value_builder/unimarc_field_115a.pl | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/cataloguing/value_builder/unimarc_field_115a.pl b/cataloguing/value_builder/unimarc_field_115a.pl >index fc0223a3e6..75b74f68e0 100755 >--- a/cataloguing/value_builder/unimarc_field_115a.pl >+++ b/cataloguing/value_builder/unimarc_field_115a.pl >@@ -32,7 +32,9 @@ sub plugin_javascript { > my ( $dbh, $record, $tagslib, $field_number ) = @_; > my $res = " > <script> >- function Clic$field_number(i) { >+ function Clic$field_number(event) { >+ event.preventDefault(); >+ const i = event.data.id; > var defaultvalue; > try { > defaultvalue = document.getElementById(i).value; >@@ -40,7 +42,7 @@ sub plugin_javascript { > alert('error when getting '+i); > return; > } >- window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_115a.pl&index=$field_number&result=\"+defaultvalue,\"unimarc_field_115a\",'width=1200,height=600,toolbar=false,scrollbars=yes'); >+ window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_115a.pl&index=\" + i + \"&result=\"+defaultvalue,\"unimarc_field_115a\",'width=1200,height=600,toolbar=false,scrollbars=yes'); > } > > </script> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32828
:
146093
|
146764
|
146938
| 147369