Bugzilla – Attachment 14763 Details for
Bug 9451
borrower_stats.pl gives off warnings and is not Plack-compatible
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9451: Quiet warnings and Plackify borrower_stats.pl
Bug-9451-Quiet-warnings-and-Plackify-borrowerstats.patch (text/plain), 1.81 KB, created by
Jared Camins-Esakov
on 2013-01-22 23:50:58 UTC
(
hide
)
Description:
Bug 9451: Quiet warnings and Plackify borrower_stats.pl
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2013-01-22 23:50:58 UTC
Size:
1.81 KB
patch
obsolete
>From cdde48d20325b772f2f7219957ddd13da42cbb58 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Tue, 22 Jan 2013 18:40:25 -0500 >Subject: [PATCH] Bug 9451: Quiet warnings and Plackify borrower_stats.pl > >There are several warnings and one non-Plack-compatible variable in >reports/borrower_stats.pl. > >To test: >1) Apply patch >2) Use the borrower report wizard to create a report that includes an > extended patron attribute. >3) Check the logs, and make sure that you don't see any of the > following messages: > Variable "$period" is not available at > /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. > Use of uninitialized value in hash element at > /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375. > Use of uninitialized value in hash element at > /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376. >--- > reports/borrowers_stats.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/reports/borrowers_stats.pl b/reports/borrowers_stats.pl >index 6fab3a4..db0943f 100755 >--- a/reports/borrowers_stats.pl >+++ b/reports/borrowers_stats.pl >@@ -54,7 +54,7 @@ my @filters = $input->param("Filter"); > $filters[3]=format_date_in_iso($filters[3]); > $filters[4]=format_date_in_iso($filters[4]); > my $digits = $input->param("digits"); >-my $period = $input->param("period"); >+our $period = $input->param("period"); > my $borstat = $input->param("status"); > my $borstat1 = $input->param("activity"); > my $output = $input->param("output"); >@@ -298,6 +298,7 @@ sub calculate { > # warn " init table : $row->{rowtitle} / $col->{coltitle} "; > $table{$row->{rowtitle}}->{$col->{coltitle}}=0; > } >+ $row->{rowtitle} ||= ''; > $table{$row->{rowtitle}}->{totalrow}=0; > $table{$row->{rowtitle}}->{rowtitle_display} = $row->{rowtitle_display}; > } >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9451
:
14763
|
15153
|
15157