From 2834da6785c262a8d4990b15b59a0aad151c81d4 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 3 Mar 2023 13:40:03 +0000 Subject: [PATCH] Bug 33126: Markup error in staff interface tab wrapper This patch makes a minor correction to the tab WRAPPER directives: a
  • which should be
  • . The patch also modifies the example WRAPPER markup to correct an error and clarify usage. To test, apply the patch and test a page which has been updated to use tab wrappers: The about page, basket groups, library transfer limits. Tabs should continue to work as expected. Before the patch, the about page source will include this:
  • After the patch the closing
  • will be correct. --- .../intranet-tmpl/prog/en/includes/html_helpers.inc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc index 758c7ba8d0..4a0bb86251 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc @@ -343,15 +343,15 @@ [% END %] [%# BOOTSTRAP TAB WRAPPER USAGE - [ WRAPPER tabs id= "tabs container id" ] + [ WRAPPER tabs id= "tabs_container_id" ] [ WRAPPER tabs_nav ] - [ WRAPPER tab_item tabname= "tab name 1" bt_active= 1 ] [ content ] [ END ] - [ WRAPPER tab_item tabname= "tab name 2" ] [ content ] [ END ] + [ WRAPPER tab_item tabname= "tab_name_1" bt_active= 1 ] Tab text 1 [ END ] + [ WRAPPER tab_item tabname= "tab_name_2" ] Tab text 2 [ END ] ... [ END ] [ WRAPPER tab_panels ] - [ WRAPPER tab_panel id="tab name 1" bt_active= 1 ] [ content ] [ END ] - [ WRAPPER tab_panel id="tab name 2"] [ content ] [ END ] + [ WRAPPER tab_panel tabname="tab_name_1" bt_active= 1 ] Panel contents 1 [ END ] + [ WRAPPER tab_panel tabname="tab_name_2" ] Panel contents 2 [ END ] ... [ END ] [ END ] @@ -382,7 +382,7 @@ [% content | $raw %] -
  • +
  • [% END %] [% BLOCK tab_panels %] -- 2.30.2