From b8018a73d0a3d2f927ed5f1873cff7b0d81470c9 Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Wed, 23 Jan 2013 10:31:31 +0000 Subject: [PATCH] Bug 9455: Remove unnecessary quoting from sql Wa've removed the mysql specific back quotes from sql files But this case remained of them embedded in an sql string Also removed the unnecessary call to finish and temporary variable in the subroutine return --- C4/Acquisition.pm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index 4a03e2c..ef4ab7c 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -798,14 +798,12 @@ Returns a reference to the array of all the basketgroups of bookseller $booksell sub GetBasketgroups { my $booksellerid = shift; - die "bookseller id is required to edit a basketgroup" unless $booksellerid; - my $query = "SELECT * FROM aqbasketgroups WHERE booksellerid=? ORDER BY `id` DESC"; + die 'bookseller id is required to edit a basketgroup' unless $booksellerid; + my $query = 'SELECT * FROM aqbasketgroups WHERE booksellerid=? ORDER BY id DESC'; my $dbh = C4::Context->dbh; my $sth = $dbh->prepare($query); $sth->execute($booksellerid); - my $results = $sth->fetchall_arrayref({}); - $sth->finish; - return $results + return $sth->fetchall_arrayref({}); } #------------------------------------------------------------# -- 1.8.1.1.347.g9591fcc