Bugzilla – Attachment 147777 Details for
Bug 33145
Invalid specification for ERM routes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33145: Fix ERM swagger specs
Bug-33145-Fix-ERM-swagger-specs.patch (text/plain), 3.88 KB, created by
Martin Renvoize
on 2023-03-06 10:04:34 UTC
(
hide
)
Description:
Bug 33145: Fix ERM swagger specs
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2023-03-06 10:04:34 UTC
Size:
3.88 KB
patch
obsolete
>From 146bcd805add2acde80f0c6553de87a098b4387e Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 6 Mar 2023 10:02:04 +0000 >Subject: [PATCH] Bug 33145: Fix ERM swagger specs > >This patch adds the missing 'Provider name' parameter definition to the >various ERM paths that were missing it. > >Test plan >1) Install swagger-cli using npm >2) cd api/v1/swagger >3) Run `swagger-cli validate swagger.yaml` >4) Confirm validation fails >5) Apply the patch here >6) Re-run the swagger-cli test above and confirm it now passes. >--- > api/v1/swagger/paths/erm_eholdings_packages.yaml | 15 +++++++++++++++ > api/v1/swagger/paths/erm_eholdings_titles.yaml | 16 +++++++++++++++- > .../paths/erm_eholdings_titles_resources.yaml | 5 +++++ > 3 files changed, 35 insertions(+), 1 deletion(-) > >diff --git a/api/v1/swagger/paths/erm_eholdings_packages.yaml b/api/v1/swagger/paths/erm_eholdings_packages.yaml >index 604f6bba08..51899e3316 100644 >--- a/api/v1/swagger/paths/erm_eholdings_packages.yaml >+++ b/api/v1/swagger/paths/erm_eholdings_packages.yaml >@@ -113,6 +113,11 @@ > produces: > - application/json > parameters: >+ - description: Provider name >+ in: path >+ name: provider >+ required: true >+ type: string > - description: A JSON object containing information about the new package > in: body > name: body >@@ -229,6 +234,11 @@ > produces: > - application/json > parameters: >+ - description: Provider name >+ in: path >+ name: provider >+ required: true >+ type: string > - $ref: "../swagger.yaml#/parameters/eholdings_package_id_pp" > - name: body > in: body >@@ -291,6 +301,11 @@ > produces: > - application/json > parameters: >+ - description: Provider name >+ in: path >+ name: provider >+ required: true >+ type: string > - $ref: "../swagger.yaml#/parameters/eholdings_package_id_pp" > responses: > 204: >diff --git a/api/v1/swagger/paths/erm_eholdings_titles.yaml b/api/v1/swagger/paths/erm_eholdings_titles.yaml >index d09627bc80..b8a58dfbe6 100644 >--- a/api/v1/swagger/paths/erm_eholdings_titles.yaml >+++ b/api/v1/swagger/paths/erm_eholdings_titles.yaml >@@ -190,6 +190,11 @@ > produces: > - application/json > parameters: >+ - description: Provider name >+ in: path >+ name: provider >+ required: true >+ type: string > - description: A JSON object containing information about the new title > in: body > name: body >@@ -304,6 +309,11 @@ > produces: > - application/json > parameters: >+ - description: Provider name >+ in: path >+ name: provider >+ required: true >+ type: string > - $ref: "../swagger.yaml#/parameters/eholdings_title_id_pp" > - name: body > in: body >@@ -366,6 +376,11 @@ > produces: > - application/json > parameters: >+ - description: Provider name >+ in: path >+ name: provider >+ required: true >+ type: string > - $ref: "../swagger.yaml#/parameters/eholdings_title_id_pp" > responses: > 204: >@@ -403,7 +418,6 @@ > x-koha-authorization: > permissions: > erm: 1 >- > /erm/eholdings/local/titles/import: > post: > x-mojo-to: ERM::EHoldings::Titles#import_from_list >diff --git a/api/v1/swagger/paths/erm_eholdings_titles_resources.yaml b/api/v1/swagger/paths/erm_eholdings_titles_resources.yaml >index 1a871bfb9f..d5ce1e62d0 100644 >--- a/api/v1/swagger/paths/erm_eholdings_titles_resources.yaml >+++ b/api/v1/swagger/paths/erm_eholdings_titles_resources.yaml >@@ -9,6 +9,11 @@ > produces: > - application/json > parameters: >+ - description: Provider name >+ in: path >+ name: provider >+ required: true >+ type: string > - description: Case insensitive search on resource_id > in: query > name: resource_id >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33145
:
147777
|
147780
|
147782