Bugzilla – Attachment 148014 Details for
Bug 33161
Implement +strings for GET /items and GET /items/:item_id
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33161: Make stub method throw an exception
Bug-33161-Make-stub-method-throw-an-exception.patch (text/plain), 1.03 KB, created by
Tomás Cohen Arazi
on 2023-03-09 14:58:08 UTC
(
hide
)
Description:
Bug 33161: Make stub method throw an exception
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2023-03-09 14:58:08 UTC
Size:
1.03 KB
patch
obsolete
>From a5c48809c3e6aa116b5f9c4651822f327ded38c7 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 9 Mar 2023 11:52:02 -0300 >Subject: [PATCH] Bug 33161: Make stub method throw an exception > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Object.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/Object.pm b/Koha/Object.pm >index e463f949205..4ab49db28bd 100644 >--- a/Koha/Object.pm >+++ b/Koha/Object.pm >@@ -687,13 +687,13 @@ being hashrefs containing 'str', 'type' and optionally 'category'. > > This is then used in to_api to render the _strings embed when requested. > >-Note: this only returns an empty I<hashref>. Each class should have its >-own mapping returned. >+Note: this method throws an exception, so devs get reminded adding I<+strings> >+to the spec is not enough. Each class should have its own mapping returned. > > =cut > > sub strings_map { >- return {}; >+ Koha::Exception->throw("This method needs to be subclassed"); > } > > =head3 public_read_list >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33161
:
147888
|
147973
|
147977
|
147995
|
147998
|
147999
|
148010
|
148011
|
148012
|
148013
|
148014
|
148039
|
148040
|
148041
|
148042
|
148043
|
148059
|
148060
|
148061
|
148062
|
148063
|
148068
|
148075