From 48a2f978e75710d84c304d2ee3aa398f55038dac Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 9 Mar 2023 11:36:27 -0300 Subject: [PATCH] Bug 33161: (follow-up) Remove stray variables and fix POD Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize --- Koha/Item.pm | 3 --- Koha/Object.pm | 5 ++--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/Koha/Item.pm b/Koha/Item.pm index 2f77660568..b9c591b973 100644 --- a/Koha/Item.pm +++ b/Koha/Item.pm @@ -2081,9 +2081,6 @@ sub strings_map { my ( $itemtagfield, $itemtagsubfield ) = C4::Biblio::GetMarcFromKohaField("items.itemnumber"); - my $public_read_list = $params->{public} ? $self->public_read_list : []; - my $to_api_mapping = $self->to_api_mapping; - # Hardcoded known 'authorised_value' values mapped to API codes my $code_to_type = { branches => 'library', diff --git a/Koha/Object.pm b/Koha/Object.pm index d01cf1e028..e463f94920 100644 --- a/Koha/Object.pm +++ b/Koha/Object.pm @@ -678,15 +678,14 @@ sub to_api_mapping { =head3 strings_map - my $params = { is_public => 1 }; my $string_map = $object->strings_map($params); Generic method that returns the string map for coded attributes. Return should be a hashref keyed on database field name with the values -being hashrefs containing 'str', 'type' and optionally 'category'. +being hashrefs containing 'str', 'type' and optionally 'category'. -This is then use in to_api to render the _strings embed when requested. +This is then used in to_api to render the _strings embed when requested. Note: this only returns an empty I. Each class should have its own mapping returned. -- 2.39.2