Bugzilla – Attachment 148154 Details for
Bug 33203
Overdue notice/status triggers letter selection is ambiguous
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33203: Add letter_code to the letter dropdown text
Bug-33203-Add-lettercode-to-the-letter-dropdown-te.patch (text/plain), 2.31 KB, created by
ByWater Sandboxes
on 2023-03-14 09:57:43 UTC
(
hide
)
Description:
Bug 33203: Add letter_code to the letter dropdown text
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2023-03-14 09:57:43 UTC
Size:
2.31 KB
patch
obsolete
>From 4fd20e37d19e379cddcaaedb4152bea1bf56e0e0 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 10 Mar 2023 21:56:57 +0000 >Subject: [PATCH] Bug 33203: Add letter_code to the letter dropdown text > >To test: >1. Add a new notice in the Circulation module with a letter code of 'ABC'. Give the new notice a name of 'Overdue notice'. >2. Now to go Overdue notice/status triggers and look at the dropdown, notice 2 choices that both read 'Overdue notice'. >3. Apply patch and try again. >4. The new notice should now read "Overdue notice (ABC)" and should be easy to distinguish from the original. > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt >index 377ac80fd2..2f9f94ba29 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt >@@ -122,9 +122,9 @@ > <option value="">No notice</option> > [% FOREACH letter IN letters %] > [% IF letter.code == value.selected_lettercode %] >- <option value="[% letter.code | html %]" selected="selected">[% letter.name | html %]</option> >+ <option value="[% letter.code | html %]" selected="selected">[% letter.name | html %] ( [% letter.code | html %] )</option> > [% ELSE %] >- <option value="[% letter.code | html %]">[% letter.name | html %]</option> >+ <option value="[% letter.code | html %]">[% letter.name | html %] ( [% letter.code | html %] )</option> > [% END %] > [% END %] > </select> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33203
:
148100
|
148154
|
150352