From 375fbd1704d9f5d7d6bc729c7d2c514ccc94bb3b Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Wed, 7 Dec 2022 18:41:26 +0000 Subject: [PATCH] Bug 32421: Add collection column to holds to pull To test: 1. Place some holds 2. Go to Circulation > Holds to pull 3. Notice there is not column to indicate collection ( CCODE ) 4. Apply patch and restart services 5. Step 2 again, this time you should see a column for holds to pull 6. Using both the Columns button and via 'Table setting' attempt to hide the column and other columns. Ensure everything is being heiiden correctly. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Bug 32421: (follow-up) Correct table settings Signed-off-by: Laura Escamilla Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- admin/columns_settings.yml | 2 ++ circ/pendingreserves.pl | 1 + .../prog/en/modules/circ/pendingreserves.tt | 9 +++++++++ 3 files changed, 12 insertions(+) diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml index a4163be70b4..aa29dfd4d62 100644 --- a/admin/columns_settings.yml +++ b/admin/columns_settings.yml @@ -1541,6 +1541,8 @@ modules: columnname: itemtypes - columnname: locations + - + columnname: collection - columnname: hold_date - diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl index 07df53bc3cc..21016bc3541 100755 --- a/circ/pendingreserves.pl +++ b/circ/pendingreserves.pl @@ -269,6 +269,7 @@ foreach my $bibnum ( @biblionumbers ){ # get available values for each biblio my $fields = { + collections => 'ccode', locations => 'location', callnumbers => 'itemcallnumber', enumchrons => 'enumchron', diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt index 98ee66fcbb3..5d44bf09e77 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt @@ -80,6 +80,7 @@ Available enumeration Available item types Available locations + Available collections Earliest hold date Hold notes Pickup location @@ -191,6 +192,13 @@ [% END %] + +
    + [% FOREACH ccode IN hold_info.collections %] +
  • [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => ccode ) | html %]
  • + [% END %] +
+ [% hold.reservedate | $KohaDates %] in [% Branches.GetName ( hold.branchcode ) | html %] @@ -259,6 +267,7 @@ + -- 2.34.1