From 3faa7eff7bce0623c903bcf50b7a4f75327b90f7 Mon Sep 17 00:00:00 2001 From: Jacob O'Mara Date: Thu, 19 Jan 2023 12:10:57 +0000 Subject: [PATCH] Bug 31933: Import patrons fails when patron attribute value contains a comma Following on from our chat I have amended the documentation to reflect the required format for csv files and the issues with smart quotes. I have also included a reference csv download so users have a dummy file they can refer to for the correct format. Test Plan: 1. Navigate to the Import Patrons tool page 2. Observe the incorrect information in the notes box to the right (blue background) 3. Apply Patch 4. Observe that the documentation has now changed to reflect the above. 5. Test the CSV file download and check is in correct format. Signed-off-by: Sally --- .../prog/en/modules/tools/import_borrowers.tt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt index f271fc58ff..d630e74fcd 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt @@ -391,7 +391,12 @@ [% IF ( Koha.Preference('ExtendedPatronAttributes') ) %]
  • - If loading patron attributes, the 'patron_attributes' field should contain a comma-separated list of attribute types and values. The attribute type code and a colon should precede each value. For example: INSTID:12345,LANG:fr or STARTDATE:January 1 2010,TRACK:Day. If an input record has more than one attribute, the fields should either be entered as an unquoted string (previous examples), or with each field wrapped in separate double quotes and delimited by a comma: "STARTDATE:January 1, 2010","TRACK:Day". The second syntax would be required if the data might have a comma in it, like a date string. + If loading patron attributes, the 'patron_attributes' field should contain a comma-separated list of attribute types and values. The attribute type code and a colon should precede each value and each attribute should be bounded in double quotes. For example: "INSTID:12345","LANG:fr" or "STARTDATE:January 1 2010","TRACK:Day". It is also very important that smart quotes are disabled in your spreadsheet editor as this can cause the patron import to fail. Here is an example file of how this should look: + + Click Here +
  • [% END %] -- 2.30.2