From 7d61d67a9169ca71f632b3a19edfeec934c18bf2 Mon Sep 17 00:00:00 2001 From: Janusz Kaczmarek Date: Wed, 15 Mar 2023 20:25:53 +0100 Subject: [PATCH] Bug 33238 (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions Content-Type: text/plain; charset="utf-8" With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions. In errorlog you would find "DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous". Test plan: ========== 1. Have a Koha instance with IndependentBranches, some accepted suggestions, and a vendor defined. 2. Be a non superlibrarian librarian with permissions to manage acquisitions. 3. Create a new basket and try to add an item to the basket "From a suggestion". 4. Koha would generate error 500. 5. Apply the patch. 6. Try to add an item to the basket "From a suggestion". 7. You should succeed. --- Koha/Suggestions.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/Suggestions.pm b/Koha/Suggestions.pm index 9b1d266586..fe40715854 100644 --- a/Koha/Suggestions.pm +++ b/Koha/Suggestions.pm @@ -56,7 +56,7 @@ sub search_limited { # from other libraries) my $userenv = C4::Context->userenv; - $resultset = $self->search({ branchcode => $userenv->{branch} }) + $resultset = $self->search({ 'me.branchcode' => $userenv->{branch} }) if $userenv && $userenv->{branch}; } -- 2.30.2