Bugzilla – Attachment 148344 Details for
Bug 32334
Sync comments in database with schema
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32334: (QA follow-up) Remove unused modules
Bug-32334-QA-follow-up-Remove-unused-modules.patch (text/plain), 1.79 KB, created by
David Nind
on 2023-03-17 13:34:13 UTC
(
hide
)
Description:
Bug 32334: (QA follow-up) Remove unused modules
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-03-17 13:34:13 UTC
Size:
1.79 KB
patch
obsolete
>From 2c7e8370ef4ad63cac0535c8a8905f5eac41c915 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 15 Feb 2023 13:05:55 +0000 >Subject: [PATCH] Bug 32334: (QA follow-up) Remove unused modules > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/Database/Commenter.pm | 1 - > misc/maintenance/sync_db_comments.pl | 1 - > t/db_dependent/Koha/Database/Commenter.t | 4 ---- > 3 files changed, 6 deletions(-) > >diff --git a/Koha/Database/Commenter.pm b/Koha/Database/Commenter.pm >index c70b0add94..66d8d05ce9 100644 >--- a/Koha/Database/Commenter.pm >+++ b/Koha/Database/Commenter.pm >@@ -18,7 +18,6 @@ package Koha::Database::Commenter; > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; >-use Data::Dumper qw(Dumper); > use File::Slurp qw(read_file); > > use Koha::Exceptions; >diff --git a/misc/maintenance/sync_db_comments.pl b/misc/maintenance/sync_db_comments.pl >index c5eb8cfdbc..3382467e5b 100755 >--- a/misc/maintenance/sync_db_comments.pl >+++ b/misc/maintenance/sync_db_comments.pl >@@ -20,7 +20,6 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; >-use Data::Dumper qw(Dumper); > use Getopt::Long qw( GetOptions ); > use Pod::Usage qw( pod2usage ); > >diff --git a/t/db_dependent/Koha/Database/Commenter.t b/t/db_dependent/Koha/Database/Commenter.t >index 09ad771c51..cf1375311e 100755 >--- a/t/db_dependent/Koha/Database/Commenter.t >+++ b/t/db_dependent/Koha/Database/Commenter.t >@@ -1,14 +1,10 @@ > #!/usr/bin/perl > > use Modern::Perl; >-use Data::Dumper qw/Dumper/; > use File::Temp qw(); >-#use Test::MockModule; > use Test::More tests => 2; > use Test::Exception; > >-#use t::lib::Mocks; >- > use C4::Context; > use Koha::Database; > use Koha::Database::Commenter; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32334
:
144391
|
144392
|
144393
|
144394
|
146712
|
146713
|
146714
|
146715
|
146716
|
146717
|
146718
|
146719
|
146720
|
148266
|
148299
|
148335
|
148338
|
148339
|
148340
|
148341
|
148342
|
148343
|
148344
|
148345
|
148346
|
148347
|
148348
|
149259
|
149260
|
149261
|
149262
|
149263
|
149264
|
149265
|
149266
|
149267
|
149268
|
149269
|
149270