@@ -, +, @@ --- Koha/QueryParser/Driver/PQF.pm | 4 ++-- Koha/QueryParser/Driver/PQF/Util.pm | 16 ++++++++++++++++ Koha/QueryParser/Driver/PQF/query_plan.pm | 6 ++++++ Koha/QueryParser/Driver/PQF/query_plan/facet.pm | 6 ++++++ Koha/QueryParser/Driver/PQF/query_plan/filter.pm | 6 ++++++ Koha/QueryParser/Driver/PQF/query_plan/modifier.pm | 6 ++++++ Koha/QueryParser/Driver/PQF/query_plan/node.pm | 6 ++++++ .../QueryParser/Driver/PQF/query_plan/node/atom.pm | 6 ++++++ OpenILS/QueryParser.pm | 18 +++++++++--------- 9 files changed, 63 insertions(+), 11 deletions(-) --- a/Koha/QueryParser/Driver/PQF.pm +++ a/Koha/QueryParser/Driver/PQF.pm @@ -338,7 +338,7 @@ sub bib1_mapping_by_attr_string { } =head2 clear_all_configuration - + $QParser->clear_all_configuration Clear all configuration. This is a highly destructive method. You may @@ -370,7 +370,7 @@ sub clear_all_configuration { } =head2 clear_all_mappings - + $QParser->clear_all_mappings Clear all bib-1 mappings. --- a/Koha/QueryParser/Driver/PQF/Util.pm +++ a/Koha/QueryParser/Driver/PQF/Util.pm @@ -4,6 +4,22 @@ use Scalar::Util qw(looks_like_number); use strict; use warnings; +=head1 NAME + + Koha::QueryParser::Driver::PQF::Util - Utility module for PQF QueryParser driver + +=head1 FUNCTIONS + +=head2 attributes_to_attr_string + + Koha::QueryParser::Driver::PQF::Util(%attributes); + + Koha::QueryParser::Driver::PQF::Util({ '1' => '1003', '4' => '6' }); + +Convert a hashref with a Bib-1 mapping into its PQF string representation. + +=cut + sub attributes_to_attr_string { my ($attributes) = @_; my $attr_string = ''; --- a/Koha/QueryParser/Driver/PQF/query_plan.pm +++ a/Koha/QueryParser/Driver/PQF/query_plan.pm @@ -4,6 +4,12 @@ use base 'OpenILS::QueryParser::query_plan'; use strict; use warnings; +=head1 NAME + +Koha::QueryParser::Driver::PQF::query_plan - query_plan subclass for PQF driver + +=head1 FUNCTIONS + =head2 Koha::QueryParser::Driver::PQF::query_plan::target_syntax my $pqf = $query_plan->target_syntax($server); --- a/Koha/QueryParser/Driver/PQF/query_plan/facet.pm +++ a/Koha/QueryParser/Driver/PQF/query_plan/facet.pm @@ -4,6 +4,12 @@ use base 'OpenILS::QueryParser::query_plan::facet'; use strict; use warnings; +=head1 NAME + +Koha::QueryParser::Driver::PQF::query_plan::facet - facet subclass for PQF driver + +=head1 FUNCTIONS + =head2 Koha::QueryParser::Driver::PQF::query_plan::facet::target_syntax my $pqf = $facet->target_syntax($server); --- a/Koha/QueryParser/Driver/PQF/query_plan/filter.pm +++ a/Koha/QueryParser/Driver/PQF/query_plan/filter.pm @@ -4,6 +4,12 @@ use base 'OpenILS::QueryParser::query_plan::filter'; use strict; use warnings; +=head1 NAME + +Koha::QueryParser::Driver::PQF::query_plan::filter - filter subclass for PQF driver + +=head1 FUNCTIONS + =head2 Koha::QueryParser::Driver::PQF::query_plan::filter::target_syntax my $pqf = $filter->target_syntax($server); --- a/Koha/QueryParser/Driver/PQF/query_plan/modifier.pm +++ a/Koha/QueryParser/Driver/PQF/query_plan/modifier.pm @@ -4,6 +4,12 @@ use base 'OpenILS::QueryParser::query_plan::modifier'; use strict; use warnings; +=head1 NAME + +Koha::QueryParser::Driver::PQF::query_plan::modifer - modifier subclass for PQF driver + +=head1 FUNCTIONS + =head2 Koha::QueryParser::Driver::PQF::query_plan::modifier::target_syntax my $pqf = $modifier->target_syntax($server, $query_plan); --- a/Koha/QueryParser/Driver/PQF/query_plan/node.pm +++ a/Koha/QueryParser/Driver/PQF/query_plan/node.pm @@ -4,6 +4,12 @@ use base 'OpenILS::QueryParser::query_plan::node'; use strict; use warnings; +=head1 NAME + +Koha::QueryParser::Driver::PQF::query_plan::node - node subclass for PQF driver + +=head1 FUNCTIONS + =head2 Koha::QueryParser::Driver::PQF::query_plan::node::target_syntax my $pqf = $node->target_syntax($server); --- a/Koha/QueryParser/Driver/PQF/query_plan/node/atom.pm +++ a/Koha/QueryParser/Driver/PQF/query_plan/node/atom.pm @@ -4,6 +4,12 @@ use base 'OpenILS::QueryParser::query_plan::node::atom'; use strict; use warnings; +=head1 NAME + +Koha::QueryParser::Driver::PQF::query_plan::node::atom - atom subclass for PQF driver + +=head1 FUNCTIONS + =head2 Koha::QueryParser::Driver::PQF::query_plan::node::atom::target_syntax my $pqf = $atom->target_syntax($server); --- a/OpenILS/QueryParser.pm +++ a/OpenILS/QueryParser.pm @@ -321,7 +321,7 @@ sub operator { my $opname = shift; my $op = shift; - return undef unless ($opname); + return unless ($opname); $parser_config{$class}{operators} ||= {}; $parser_config{$class}{operators}{$opname} = $op if ($op); @@ -1488,7 +1488,7 @@ package OpenILS::QueryParser::query_plan; sub QueryParser { my $self = shift; - return undef unless ref($self); + return unless ref($self); return $self->{QueryParser}; } @@ -1540,7 +1540,7 @@ sub _merge_filters { my $right_filter = shift; my $join = shift; - return undef unless $left_filter or $right_filter; + return unless $left_filter or $right_filter; return $right_filter unless $left_filter; return $left_filter unless $right_filter; @@ -1599,7 +1599,7 @@ sub collapse_filters { sub find_filter { my $self = shift; my $needle = shift;; - return undef unless ($needle); + return unless ($needle); my $filter = $self->collapse_filters($needle); @@ -1613,7 +1613,7 @@ sub find_filter { sub find_modifier { my $self = shift; my $needle = shift;; - return undef unless ($needle); + return unless ($needle); return grep { $_->name eq $needle } @{ $self->modifiers }; } @@ -2103,25 +2103,25 @@ sub new { sub node { my $self = shift; - return undef unless (ref $self); + return unless (ref $self); return $self->{node}; } sub content { my $self = shift; - return undef unless (ref $self); + return unless (ref $self); return $self->{content}; } sub prefix { my $self = shift; - return undef unless (ref $self); + return unless (ref $self); return $self->{prefix}; } sub suffix { my $self = shift; - return undef unless (ref $self); + return unless (ref $self); return $self->{suffix}; } --