From 2205e0bae65b70ab804ebdea8c142a88410fd4c9 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 24 Jan 2013 11:50:08 +0100 Subject: [PATCH] [SIGNED-OFF] Bug 9479: The member notices page doesn't display dates in the syspref format Content-Type: text/plain; charset="utf-8" In order to let the KohaDates plugin display a datetime, this patch modify this plugin. Now it uses Koha::DateUtils instead of C4::Dates. Test plan: - check that the date format on the member notices page (members/notices.pl) is displayed according your syspref dateformat. - check that existing dates are always in the good format (without the hours) e.g. acqui/histsearch.pl, acqui/basket.pl, etc. - Modify your syspref and recheck the previous pages Signed-off-by: Owen Leonard This is a nice addition, and works according to the test plan. A nice follow-up would be to create a system pref for formatting times (12/24hr). --- Koha/Template/Plugin/KohaDates.pm | 23 ++++++++++++-------- .../prog/en/modules/members/notices.tt | 3 ++- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/Koha/Template/Plugin/KohaDates.pm b/Koha/Template/Plugin/KohaDates.pm index 00656fa..884c3e5 100644 --- a/Koha/Template/Plugin/KohaDates.pm +++ b/Koha/Template/Plugin/KohaDates.pm @@ -17,21 +17,26 @@ package Koha::Template::Plugin::KohaDates; # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -use strict; -use warnings; +use Modern::Perl; use Template::Plugin::Filter; use base qw( Template::Plugin::Filter ); -use warnings; -use strict; -use C4::Dates; +use Koha::DateUtils; +our $DYNAMIC = 1; + +sub init { + my $self = shift; + $self->{ _DYNAMIC } = 1; + return $self; +} sub filter { - my ($self,$text) = @_; - return "" if not $text; - my $date = C4::Dates->new( $text, 'iso' ); - return $date->output("syspref"); + my ( $self, $text, $args, $config ) = @_; + return "" unless $text; + $config->{with_hours} //= 0; + my $dt = dt_from_string( $text, 'iso' ); + return output_pref( $dt, undef, !$config->{with_hours} ); } 1; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt index 445ed17..5d4138a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt @@ -1,3 +1,4 @@ +[% USE KohaDates %] [% INCLUDE 'doc-head-open.inc' %] Sent notices for [% INCLUDE 'patron-title.inc' %] [% INCLUDE 'doc-head-close.inc' %] @@ -72,7 +73,7 @@ [% ELSIF ( QUEUED_MESSAGE.status == 'deleted' ) %]deleted [% ELSE %][% QUEUED_MESSAGE.status %][% END %] - [% QUEUED_MESSAGE.time_queued %] + [% QUEUED_MESSAGE.time_queued | $KohaDates with_hours => 1 %] [% END %] -- 1.7.9.5