Bugzilla – Attachment 149732 Details for
Bug 33318
[21.11] Advanced editor doesn't load
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33318: Fix JS errors on advanced cataloguing editor
Bug-33318-Fix-JS-errors-on-advanced-cataloguing-ed.patch (text/plain), 2.15 KB, created by
David Nind
on 2023-04-16 18:34:47 UTC
(
hide
)
Description:
Bug 33318: Fix JS errors on advanced cataloguing editor
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-04-16 18:34:47 UTC
Size:
2.15 KB
patch
obsolete
>From 634c8b78a60585e05c385fcaf4d1b67dacf2057d Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Wed, 22 Mar 2023 11:10:40 +0000 >Subject: [PATCH] Bug 33318: Fix JS errors on advanced cataloguing editor > >This patch reverts bug 31818 > >Test plan: >1. Checkout 21.11.x >2. Set the EnableAdvancedCatalogingEditor syspref = 'Enable' >3. Go to Cataloguing > Advanced editor >4. Notice the advanced editor is stuck on 'Loading, please wait' >5. Right click > Inspect > Console >6. Notice there is a JS error: "Uncaught TypeError: $.fn.popover.Constructor.DEFAULTS.whiteList is undefined" >7. Apply patch >8. Restart services >9. Refresh the advanced editor >10. Notice it is not stuck on 'Loading, please wait' >11. Right click > Inspect > Console >12. Notice the JS error is no longer showing >13. Click on 'Keyboard shortcuts' and confirm it contains content - that >is what bug 31818 was aiming to fix > >Sponsored-by: Toi Ohomai Institute of Technology, New Zealand > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../intranet-tmpl/prog/en/includes/cateditor-ui.inc | 9 --------- > 1 file changed, 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >index 6ef42705a6..e0a26ca213 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc >@@ -1300,15 +1300,6 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr > }, > }); > >- // Whitelist table elements to ensure popover displays all the info >- $.fn.popover.Constructor.DEFAULTS.whiteList.table = []; >- $.fn.popover.Constructor.DEFAULTS.whiteList.tr = []; >- $.fn.popover.Constructor.DEFAULTS.whiteList.td = []; >- $.fn.popover.Constructor.DEFAULTS.whiteList.div = []; >- $.fn.popover.Constructor.DEFAULTS.whiteList.tbody = []; >- $.fn.popover.Constructor.DEFAULTS.whiteList.thead = []; >- // https://getbootstrap.com/docs/3.4/javascript/#popovers >- > $('#show-shortcuts').popover({ > html: true, > placement: 'bottom', >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33318
:
148627
|
149732
|
150385