From e1689fc586458b2ef159ac0dd516391a040b1db7 Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Wed, 19 Apr 2023 21:26:17 +0000 Subject: [PATCH] Bug 33478: Add format_notices user permission --- .../bug_33478_-_add_format_notices_permission.pl | 14 ++++++++++++++ installer/data/mysql/mandatory/userpermissions.sql | 1 + .../intranet-tmpl/prog/en/includes/permissions.inc | 5 +++++ t/Koha/Auth/Permissions.t | 1 + 4 files changed, 21 insertions(+) create mode 100644 installer/data/mysql/atomicupdate/bug_33478_-_add_format_notices_permission.pl diff --git a/installer/data/mysql/atomicupdate/bug_33478_-_add_format_notices_permission.pl b/installer/data/mysql/atomicupdate/bug_33478_-_add_format_notices_permission.pl new file mode 100644 index 00000000000..d358c25f350 --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_33478_-_add_format_notices_permission.pl @@ -0,0 +1,14 @@ +use Modern::Perl; + +return { + bug_number => "33478", + description => "Customise the format of notices when they are printed", + up => sub { + my ($args) = @_; + my ($dbh, $out) = @$args{qw(dbh out)}; + + $dbh->do(q{ INSERT IGNORE INTO permissions (module_bit, code, description) VALUES (13, 'format_notices', 'Format how generated notices are laid out when printed') }); + + say $out "Added user permission format_notices"; + }, +}; diff --git a/installer/data/mysql/mandatory/userpermissions.sql b/installer/data/mysql/mandatory/userpermissions.sql index 7b6955de442..81545960397 100644 --- a/installer/data/mysql/mandatory/userpermissions.sql +++ b/installer/data/mysql/mandatory/userpermissions.sql @@ -90,6 +90,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES (13, 'moderate_comments', 'Moderate patron comments'), (13, 'edit_notices', 'Define notices'), (13, 'edit_notice_status_triggers', 'Set notice/status triggers for overdue items'), + (13, 'format_notices', 'Format how generated notices are laid out when printed'), (13, 'edit_quotes', 'Edit quotes for quote-of-the-day feature'), (13, 'view_system_logs', 'Browse the system logs'), (13, 'inventory', 'Perform inventory (stocktaking) of your catalog'), diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc index e4c4cbe2a64..62f0102f02e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc @@ -514,6 +514,11 @@ Define notices ([% name | html %]) + [%- CASE 'format_notices' -%] + + Format how generated notices are laid out when printed + + ([% name | html %]) [%- CASE 'edit_patrons' -%] Perform batch modification of patrons diff --git a/t/Koha/Auth/Permissions.t b/t/Koha/Auth/Permissions.t index d5d2b98d1c6..b4ae5a3a859 100755 --- a/t/Koha/Auth/Permissions.t +++ b/t/Koha/Auth/Permissions.t @@ -245,6 +245,7 @@ subtest 'superlibrarian tests' => sub { 'CAN_user_tools_edit_calendar' => 1, 'CAN_user_tools_edit_notice_status_triggers' => 1, 'CAN_user_tools_edit_notices' => 1, + 'CAN_user_tools_format_notices' => 1, 'CAN_user_tools_edit_patrons' => 1, 'CAN_user_tools_edit_quotes' => 1, 'CAN_user_tools_export_catalog' => 1, -- 2.30.2