From 4047a5706fe48bd865485c24b5db0b44e39d48b5 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 31 Jan 2013 15:56:13 -0500
Subject: [PATCH] Bug 9526 - Patron statistics table is not pretty, needs circ
 toolbar

This patch adds the circ/members toolbar, corrects page title and
breadcrumbs, and adds some handling for column names which are coming
from the database. The table of statistics can display any items table
column specified in the StatisticsFields preference, but we can at least
embed the most obvious cases in the template for human readability: item
type, collection code, location, home library, and holding library.

To test, view the patron statistics page. For a patron with no
statistics you should see a message saying so. For a patron with
statistics you should see human-friendly labels for the columns
referenced above.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Works as described. No errors.
Wouldn't be better with centered cell contents?

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
FIX a typo:
- <h3>Statistcs for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])</h3>
+ <h3>Statistics for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])</h3>
---
 .../prog/en/modules/members/statistics.tt          |   31 ++++++++++++++++----
 1 file changed, 25 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt
index 3ff663c..7a9f047 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt
@@ -3,7 +3,7 @@
 [% IF ( unknowuser ) %]
     Patron does not exist
 [% ELSE %]
-    Patron details for [% INCLUDE 'patron-title.inc' %]
+    Statistics for [% INCLUDE 'patron-title.inc' %]
 [% END %]
 </title>
 <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" />
@@ -31,7 +31,7 @@
 <div id="breadcrumbs">
          <a href="/cgi-bin/koha/mainpage.pl">Home</a>
 &rsaquo; <a href="/cgi-bin/koha/members/members-home.pl">Patrons</a>
-&rsaquo; [% IF ( unknowuser ) %]Patron does not exist[% ELSE %]Patron statistics for [% firstname %] [% surname %] ([% cardnumber %])[% END %]
+&rsaquo; [% IF ( unknowuser ) %]Patron does not exist[% ELSE %]Statistics for [% firstname %] [% surname %] ([% cardnumber %])[% END %]
 </div>
 
 <div id="doc3" class="yui-t1">
@@ -39,13 +39,30 @@
    <div id="bd">
     <div id="yui-main">
         <div class="yui-b">
-            <div class="yui-g">
-                <h2>Statistics</h2>
+        [% INCLUDE 'members-toolbar.inc' %]
+
+            <h3>Statistics for [% UNLESS ( I ) %][% title %] [% firstname %] [% END %] [% surname %] ([% cardnumber %])</h3>
+            [% IF ( datas.size ) %]
                 <table id="statistics">
                 <thead>
                     <tr>
                       [% FOREACH cn IN column_names %]
-                          <th>[% cn %]</th>
+                          <th>
+                            [% SWITCH cn %]
+                            [% CASE 'itype' %]
+                                Item type
+                            [% CASE 'ccode' %]
+                                Collection code
+                            [% CASE 'location' %]
+                                Shelving location
+                            [% CASE 'homebranch' %]
+                                Home library
+                            [% CASE 'holdingbranch' %]
+                                Holding library
+                            [% CASE %]
+                                [% cn %]
+                            [% END %]
+                          </th>
                       [% END %]
                       <th>Total checkouts as of yesterday</th>
                       <th>Today's checkouts</th>
@@ -73,7 +90,9 @@
                     </tr>
                 </tfoot>
                 </table>
-            </div>
+            [% ELSE %]
+                <div class="dialog message">There are no statistics for this patron.</div>
+            [% END %]
         </div>
     </div>
 <div class="yui-b">
-- 
1.7.10.4