From 4929349951ba50e17dd5e4573a1200dc40f050c2 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 21 Apr 2023 08:58:50 +0000 Subject: [PATCH] Bug 32642: (QA follow-up) Activate spinner early Content-Type: text/plain; charset=utf-8 See comment on former patch too. We need to activate the spinner early and we can simplify the code to remove it. Note: unfortunately this is kind of a workaround, since using load would be nicer but currently hard to implement since the cover image code is scattered/widespread. This code still checks the complete attribute, we could argue that it should just remove the spinner. Note too that the spinner belongs to a div where multiple img may be part of. If we do not remove the spinner now, something went wrong at load time, but if you can actually see the spinner is another thing. Test plan: See former patch. Check few cover images on detail page, enable various providers. Bonus: I tested with a sleep statement in opac-image.pl. Signed-off-by: Marcel de Rooy --- .../bootstrap/en/modules/opac-detail.tt | 20 +++++++++---------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 1f9eb3f2fa..6e62fe5f97 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -59,7 +59,7 @@