Bugzilla – Attachment 150056 Details for
Bug 33585
Remove javascript code duplication in shelf browser
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Initial patch
shelf-dedupe.patch (text/plain), 4.87 KB, created by
Virgil Dupras
on 2023-04-21 15:41:51 UTC
(
hide
)
Description:
Initial patch
Filename:
MIME Type:
Creator:
Virgil Dupras
Created:
2023-04-21 15:41:51 UTC
Size:
4.87 KB
patch
obsolete
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >index 51c89e767f..9256592acd 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc >@@ -15,7 +15,7 @@ > <td class="nav-cell" rowspan="2"> > [% IF shelfbrowser_prev_item %] > <div id="browser_previous"> >- <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% shelfbrowser_prev_item.biblionumber | uri %]&shelfbrowse_itemnumber=[% shelfbrowser_prev_item.itemnumber | uri %]#shelfbrowser" data-prev-itemnumber="[% shelfbrowser_prev_item.itemnumber | html %]"><i class="fa fa-caret-up" aria-hidden="true"></i> Previous</a> >+ <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% shelfbrowser_prev_item.biblionumber | uri %]&shelfbrowse_itemnumber=[% shelfbrowser_prev_item.itemnumber | uri %]#shelfbrowser" data-itemnumber="[% shelfbrowser_prev_item.itemnumber | html %]"><i class="fa fa-caret-up" aria-hidden="true"></i> Previous</a> > </div> > [% END %] > </td> >@@ -86,7 +86,7 @@ > <td class="nav-cell" rowspan="2"> > [% IF shelfbrowser_next_item %] > <div id="browser_next"> >- <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% shelfbrowser_next_item.biblionumber | uri %]&shelfbrowse_itemnumber=[% shelfbrowser_next_item.itemnumber | uri %]#shelfbrowser" data-next-itemnumber="[% shelfbrowser_next_item.itemnumber | html %]">Next <i class="fa fa-caret-up" aria-hidden="true"></i></a> >+ <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% shelfbrowser_next_item.biblionumber | uri %]&shelfbrowse_itemnumber=[% shelfbrowser_next_item.itemnumber | uri %]#shelfbrowser" data-itemnumber="[% shelfbrowser_next_item.itemnumber | html %]">Next <i class="fa fa-caret-up" aria-hidden="true"></i></a> > </div> > [% END %] > </td> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 6e62fe5f97..a10b7d1fec 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1866,39 +1866,13 @@ > e.preventDefault(); > $("#shelfbrowser").toggle(); > }); >- $(".main").on("click", "#browser_previous a", function(e){ >+ $(".main").on("click", "#browser_previous a, #browser_next a", function(e){ > e.preventDefault(); > $.ajax({ > url: "/cgi-bin/koha/svc/shelfbrowser.pl", > type: "POST", > data: { >- "shelfbrowse_itemnumber": $("#browser_previous a").data( "prev-itemnumber" ) >- }, >- success: function(data){ >- $("#shelfbrowser").replaceWith(data); >- [% IF ( GoogleJackets ) %] >- KOHA.Google.GetCoverFromIsbn([% covernewwindow | html %]); >- [% END %] >- [% IF ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) %] >- KOHA.coce.getURL('[% Koha.Preference('CoceHost') | html %]', '[% Koha.Preference('CoceProviders') | html %]',[% covernewwindow | html %]); >- [% END %] >- [% IF OpenLibraryCovers %] >- KOHA.OpenLibrary.GetCoverFromIsbn(); >- [% END %] >- [% IF OPACLocalCoverImages %] >- KOHA.LocalCover.GetCoverFromBibnumber(true); >- [% END %] >- } >- }); >- }); >- >- $(".main").on("click", "#browser_next a", function(e){ >- e.preventDefault(); >- $.ajax({ >- url: "/cgi-bin/koha/svc/shelfbrowser.pl", >- type: "POST", >- data: { >- "shelfbrowse_itemnumber": $("#browser_next a").data( "next-itemnumber" ) >+ "shelfbrowse_itemnumber": $(e.target).data("itemnumber") > }, > success: function(data){ > $("#shelfbrowser").replaceWith(data);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33585
: 150056