Bugzilla – Attachment 150139 Details for
Bug 33206
Bad title__sort made of multisubfield 245
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33206: Unit test
Bug-33206-Unit-test.patch (text/plain), 3.18 KB, created by
Katrin Fischer
on 2023-04-23 21:40:57 UTC
(
hide
)
Description:
Bug 33206: Unit test
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-04-23 21:40:57 UTC
Size:
3.18 KB
patch
obsolete
>From a877a07ba3733747d9d6ce96d17299599543e1c1 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 17 Apr 2023 19:24:18 +0000 >Subject: [PATCH] Bug 33206: Unit test > >Signed-off-by: Nick <nick@bywatersolutions.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../Koha/SearchEngine/Elasticsearch.t | 20 ++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch.t >index 6356d9c20a..c4b8f59f72 100755 >--- a/t/db_dependent/Koha/SearchEngine/Elasticsearch.t >+++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch.t >@@ -184,7 +184,7 @@ subtest 'get_elasticsearch_mappings() tests' => sub { > > subtest 'Koha::SearchEngine::Elasticsearch::marc_records_to_documents () tests' => sub { > >- plan tests => 63; >+ plan tests => 65; > > t::lib::Mocks::mock_preference('marcflavour', 'MARC21'); > t::lib::Mocks::mock_preference('ElasticsearchMARCFormat', 'ISO2709'); >@@ -450,14 +450,25 @@ subtest 'Koha::SearchEngine::Elasticsearch::marc_records_to_documents () tests' > MARC::Field->new('999', '', '', c => '1234568'), > MARC::Field->new('952', '', '', 0 => 1, g => 'string where should be numeric', o => $long_callno), > ); >- my $records = [$marc_record_1, $marc_record_2, $marc_record_3]; >+ >+ my $marc_record_4 = MARC::Record->new(); >+ $marc_record_4->leader(' cam 22 a 4500'); >+ $marc_record_4->append_fields( >+ MARC::Field->new('008', '901111s19uu xxk|||| |00| ||eng c'), >+ MARC::Field->new('100', '', '', a => 'Author 2'), >+ MARC::Field->new('245', '', '4', a => 'The Title :', b => 'fourth record'), >+ MARC::Field->new('260', '', '', a => 'New York :', b => 'Ace ,', c => ' 89 '), >+ MARC::Field->new('999', '', '', c => '1234568'), >+ ); >+ >+ my $records = [$marc_record_1, $marc_record_2, $marc_record_3, $marc_record_4]; > > $see->get_elasticsearch_mappings(); #sort_fields will call this and use the actual db values unless we call it first > > my $docs = $see->marc_records_to_documents($records); > > # First record: >- is(scalar @{$docs}, 3, 'Two records converted to documents'); >+ is(scalar @{$docs}, 4, 'Four records converted to documents'); > > is_deeply($docs->[0]->{control_number}, ['123'], 'First record control number should be set correctly'); > >@@ -475,6 +486,9 @@ subtest 'Koha::SearchEngine::Elasticsearch::marc_records_to_documents () tests' > is(scalar @{$docs->[0]->{title__sort}}, 1, 'First document title__sort field should have a single'); > is_deeply($docs->[0]->{title__sort}, ['Title: first record Title: first record'], 'First document title__sort field should be set correctly'); > >+ is(scalar @{$docs->[3]->{title__sort}}, 1, 'First document title__sort field should have a single'); >+ is_deeply($docs->[3]->{title__sort}, ['Title : fourth record The Title : fourth record'], 'Fourth document title__sort field should be set correctly'); >+ > is($docs->[0]->{issues}, 6, 'Issues field should be sum of the issues for each item'); > is($docs->[0]->{issues__sort}, 6, 'Issues sort field should also be a sum of the issues'); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33206
:
148103
|
149772
|
149773
|
150138
| 150139