From 6ae0b09aa181d61871bbf8654bddd645672bbff7 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Thu, 29 Dec 2022 16:17:40 +0000 Subject: [PATCH] Bug 32548: Make illrequestattributes available in ILL emails Without this ILL module only provides very limited data to be included in the notices sent about the request itself. We have the columns illrequests, but not the illrequestattributes, that often will contain the more useful information needed. This patch enables to use values of the illrequestattributs using [% illrequestattributes. %] in the notices. To test: * Apply patch * First you'll need to activate the ILL module and install a backend to use it with. FreeForm was used for this test plan, BLDSS is usually also good for testing. See: https://wiki.koha-community.org/wiki/ILL_backends * Also set up an SMTP server to use for notices and make sure the email address is set in KohaAdminEmailAddress and the user you are using for testing this with. * Make sure your user has an email address and will receive ILL notices by seleting them in the messaging preferences. * Create an ILL request with the FreeForm backend for your user. * On the ILL request detail page: "Display supplier metadata" Pick some attributes you want to use in the notice * Go to Tools > Notices and slips and edit ILL_REQUEST_UNAVAIL * Add some of the attributes you picked. Example: [% illrequestattributes.type %] [% illrequestattributes.title %] * Back to the ILL request detail page: Send notice to patron > ILL request unavailable * Go to your patron's account and check the notices tab * The generated notice shoudl show and include the information from the illrequestattributes you picked. Signed-off-by: Pedro Amorim Signed-off-by: Nick Clemens --- Koha/Illrequest.pm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm index d160c152b8..21e94660ca 100644 --- a/Koha/Illrequest.pm +++ b/Koha/Illrequest.pm @@ -1650,6 +1650,13 @@ sub get_notice { push @metaarray, "- $key: $value" if $value; } my $metastring = join("\n", @metaarray); + + my $illrequestattributes = {}; + my $attributes = $self->illrequestattributes; + while ( my $attribute = $attributes->next ) { + $illrequestattributes->{$attribute->type} = $attribute->value; + } + my $letter = C4::Letters::GetPreparedLetter( module => 'ill', letter_code => $params->{notice_code}, @@ -1666,7 +1673,8 @@ sub get_notice { ill_bib_title => $title ? $title->value : '', ill_bib_author => $author ? $author->value : '', ill_full_metadata => $metastring, - additional_text => $params->{additional_text} + additional_text => $params->{additional_text}, + illrequestattributes => $illrequestattributes, } ); -- 2.30.2