Bugzilla – Attachment 150556 Details for
Bug 33419
Make home library and holding library in items mandatory by default
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33419: (QA follow-up) Remove changes to basic_workflow.t
Bug-33419-QA-follow-up-Remove-changes-to-basicwork.patch (text/plain), 2.41 KB, created by
Katrin Fischer
on 2023-05-02 22:50:31 UTC
(
hide
)
Description:
Bug 33419: (QA follow-up) Remove changes to basic_workflow.t
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-05-02 22:50:31 UTC
Size:
2.41 KB
patch
obsolete
>From fc97016a3aa29da51f2125fa5a760f5d8628b324 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Tue, 2 May 2023 22:48:09 +0000 >Subject: [PATCH] Bug 33419: (QA follow-up) Remove changes to basic_workflow.t > >These are not needed: 942 and 200 have no subfields for >homebranch and holdingbranch. > >The tests pass without these changes. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > t/db_dependent/selenium/basic_workflow.t | 13 ------------- > 1 file changed, 13 deletions(-) > >diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t >index a4a05f7775..fc6ab44d4f 100755 >--- a/t/db_dependent/selenium/basic_workflow.t >+++ b/t/db_dependent/selenium/basic_workflow.t >@@ -132,10 +132,6 @@ SKIP: { > > my $itemtype = $sample_data->{itemtype}; > >- my $homelibrary = $sample_data->{homelibrary}; >- >- my $currentlibrary = $sample_data->{currentlibrary}; >- > my @biblionumbers; > for my $i ( 1 .. $number_of_biblios_to_insert ) { > my $biblio = MARC::Record->new(); >@@ -145,16 +141,12 @@ SKIP: { > MARC::Field->new('200', ' ', ' ', a => 'test biblio '.$i), > MARC::Field->new('200', ' ', ' ', f => 'test author '.$i), > MARC::Field->new('200', ' ', ' ', b => $itemtype->{itemtype}), >- MARC::Field->new('200', ' ', ' ', c => $homelibrary->{homelibrary}), >- MARC::Field->new('200', ' ', ' ', d => $currentlibrary->{currentlibrary}), > ); > } else { > $biblio->append_fields( > MARC::Field->new('245', ' ', ' ', a => 'test biblio '.$i), > MARC::Field->new('100', ' ', ' ', a => 'test author '.$i), > MARC::Field->new('942', ' ', ' ', c => $itemtype->{itemtype}), >- MARC::Field->new('942', ' ', ' ', b => $homelibrary->{homelibrary}), >- MARC::Field->new('942', ' ', ' ', d => $currentlibrary->{currentlibrary}), > ); > } > my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, ''); >@@ -219,11 +211,6 @@ SKIP: { > ) { > next; # auto-filled > } >- elsif ( >- $id =~ m|^tag_952_subfield_a| # homelibrary >- ) { >- elsif ( =~ m|^tag_952_subfield_b| # currentlibrary >- ) { > elsif ( > $id =~ m|^tag_952_subfield_d| # dateaccessioned > ) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33419
:
149211
|
149213
|
149214
|
149218
|
150462
|
150530
|
150531
|
150532
|
150553
|
150555
| 150556