From ffcc7890036f709e842c5c408ea85941142e486b Mon Sep 17 00:00:00 2001 From: Chris Cormack Date: Sat, 2 Feb 2013 19:59:42 +1300 Subject: [PATCH] [SIGNED-OFF] Bug 8942 : Adding a test to make sure we don't use single quotes for js Content-Type: text/plain; charset="utf-8" Signed-off-by: Owen Leonard Tested by adding single quotes to a translation-escaped string. Test correctly failed it. --- xt/single_quotes.t | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100755 xt/single_quotes.t diff --git a/xt/single_quotes.t b/xt/single_quotes.t new file mode 100755 index 0000000..b123a6d --- /dev/null +++ b/xt/single_quotes.t @@ -0,0 +1,40 @@ +#!/usr/bin/perl + +# Copyright (C) 2013 Horowhenua Library Trust +# +# This file is part of Koha. +# +# Koha is free software; you can redistribute it and/or modify it under the +# terms of the GNU General Public License as published by the Free Software +# Foundation; either version 3 of the License, or (at your option) any later +# version. +# +# Koha is distributed in the hope that it will be useful, but WITHOUT ANY +# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR +# A PARTICULAR PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License along +# with Koha; if not, write to the Free Software Foundation, Inc., +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + +use warnings; +use strict; +use Test::More tests => 1; +use File::Find; + +my @files; +find( + sub { + open my $fh, $_ or die "Could not open $_: $!"; + my @lines = sort grep /\_\(\'/, <$fh>; + push @files, { name => "$_", lines => \@lines } if @lines; + }, + ( "./koha-tmpl/opac-tmpl/prog/en", "./koha-tmpl/intranet-tmpl/prog/en" ) +); + +ok( !@files, "Files do not contain single quotes _(' " ) + or diag( + "Files list: \n", + join( "\n", + map { $_->{name} . ': ' . join( ', ', @{ $_->{lines} } ) } @files ) + ); -- 1.7.9.5