Bugzilla – Attachment 150639 Details for
Bug 17427
Replace CGI::Session with Data::Session
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17427: Fix id vs userid in tests
Bug-17427-Fix-id-vs-userid-in-tests.patch (text/plain), 3.30 KB, created by
Jonathan Druart
on 2023-05-04 10:08:35 UTC
(
hide
)
Description:
Bug 17427: Fix id vs userid in tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-05-04 10:08:35 UTC
Size:
3.30 KB
patch
obsolete
>From e3abdd241f14b0518cc8219af7f224d06e864342 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 4 May 2023 12:03:59 +0200 >Subject: [PATCH] Bug 17427: Fix id vs userid in tests > >--- > t/db_dependent/api/v1/auth.t | 2 +- > t/db_dependent/api/v1/auth_authenticate_api_request.t | 2 +- > t/db_dependent/api/v1/idp.t | 2 +- > t/db_dependent/api/v1/two_factor_auth.t | 4 ++-- > 4 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/api/v1/auth.t b/t/db_dependent/api/v1/auth.t >index 9e550c61b05..0cce9fef098 100755 >--- a/t/db_dependent/api/v1/auth.t >+++ b/t/db_dependent/api/v1/auth.t >@@ -146,7 +146,7 @@ sub create_user_and_session { > # Create a session for the authorized user > my $session = C4::Auth::get_session(''); > $session->param( 'number', $user->{borrowernumber} ); >- $session->param( 'id', $user->{userid} ); >+ $session->param( 'userid', $user->{userid} ); > $session->param( 'ip', '127.0.0.1' ); > $session->param( 'lasttime', time() ); > $session->flush; >diff --git a/t/db_dependent/api/v1/auth_authenticate_api_request.t b/t/db_dependent/api/v1/auth_authenticate_api_request.t >index 9c47926e7bd..89669fa1b05 100755 >--- a/t/db_dependent/api/v1/auth_authenticate_api_request.t >+++ b/t/db_dependent/api/v1/auth_authenticate_api_request.t >@@ -330,7 +330,7 @@ sub create_user_and_session { > # Create a session for the authorized user > my $session = C4::Auth::get_session(''); > $session->param( 'number', $user->{borrowernumber} ); >- $session->param( 'id', $user->{userid} ); >+ $session->param( 'userid', $user->{userid} ); > $session->param( 'ip', '127.0.0.1' ); > $session->param( 'lasttime', time() ); > $session->flush; >diff --git a/t/db_dependent/api/v1/idp.t b/t/db_dependent/api/v1/idp.t >index 880484151e1..cab07f2e8f3 100755 >--- a/t/db_dependent/api/v1/idp.t >+++ b/t/db_dependent/api/v1/idp.t >@@ -311,7 +311,7 @@ sub create_user_and_session { > # Create a session for the authorized user > my $session = C4::Auth::get_session(''); > $session->param( 'number', $user->{borrowernumber} ); >- $session->param( 'id', $user->{userid} ); >+ $session->param( 'userid', $user->{userid} ); > $session->param( 'ip', $remote_address ); > $session->param( 'lasttime', time() ); > $session->flush; >diff --git a/t/db_dependent/api/v1/two_factor_auth.t b/t/db_dependent/api/v1/two_factor_auth.t >index 9eefa3300ad..0c41bc08a68 100755 >--- a/t/db_dependent/api/v1/two_factor_auth.t >+++ b/t/db_dependent/api/v1/two_factor_auth.t >@@ -72,7 +72,7 @@ subtest 'registration and verification' => sub { > > # Authenticated - can register > $session->param( 'number', $patron->borrowernumber ); >- $session->param( 'id', $patron->userid ); >+ $session->param( 'userid', $patron->userid ); > $session->flush; > > $patron->auth_method('password'); >@@ -177,7 +177,7 @@ subtest 'send_otp_token' => sub { > > # Patron is partially authenticated (credentials correct) > $session->param( 'number', $patron->borrowernumber ); >- $session->param( 'id', $patron->userid ); >+ $session->param( 'userid', $patron->userid ); > $session->param('waiting-for-2FA', 1); > $session->flush; > >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17427
:
56185
|
56504
|
56572
|
57067
|
60355
|
121337
|
121633
|
121657
|
121658
|
121659
|
150569
|
150570
|
150571
|
150603
|
150604
|
150605
|
150606
|
150633
|
150634
|
150635
|
150636
|
150637
|
150638
|
150639
|
150926
|
150927
|
150928
|
150929
|
150930
|
150931
|
153030
|
153031
|
153032
|
153033
|
153034
|
153035
|
153036
|
153037
|
153038
|
153039
|
153040