From dd108e98c6e8351801d1055f83ba4cdcdf795d2b Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 11 May 2023 13:48:50 +0200 Subject: [PATCH] Bug 33247: Flag the authority pending deletion in the result list When an authority is removed from the result list it is not removed from the search engine yet. This patch suggests to add a note in the summary column to tell the user that the deletion is pending. Test plan: 1 - Go to authorities home and perform a search; 2 - Delete any authority; 3 - After the confirmation, the page is refreshed but still contains the deleted authority, with a red note explaining that the deletion is pending. --- authorities/authorities-home.pl | 4 ++++ .../prog/en/modules/authorities/searchresultlist.tt | 1 + 2 files changed, 5 insertions(+) diff --git a/authorities/authorities-home.pl b/authorities/authorities-home.pl index 3ef44e8b0ce..4ae1270f3a2 100755 --- a/authorities/authorities-home.pl +++ b/authorities/authorities-home.pl @@ -46,6 +46,7 @@ my $authid = $query->param('authid') || ''; my ( $template, $loggedinuser, $cookie ); my $authority_types = Koha::Authority::Types->search( {}, { order_by => ['authtypetext'] } ); +my $pending_deletion_authid; if ( $op eq "delete" ) { ( $template, $loggedinuser, $cookie ) = get_template_and_user( @@ -64,6 +65,8 @@ if ( $op eq "delete" ) { }); DelAuthority({ authid => $authid }); + # FIXME No error handling here, DelAuthority needs adjustments + $pending_deletion_authid = $authid; if ( $query->param('operator') ) { # query contains search params so perform search @@ -247,6 +250,7 @@ my $servers = Koha::Z3950Servers->search( $template->param( servers => $servers, authority_types => $authority_types, + pending_deletion_authid => $pending_deletion_authid, op => $op, ); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt index 3011dfb690e..e7cc54a71f6 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt @@ -77,6 +77,7 @@ [% ELSE %] [% PROCESS authresult summary=resul.summary authid=resul.authid %] [% END %] + [% IF pending_deletion_authid == resul.authid %]Pending deletion[% END %] [% resul.authtype | html %] [% UNLESS ( resul.isEDITORS ) %] -- 2.25.1