From 6e1066466b73869636318bdb2b9e55efd0c73b74 Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Thu, 11 May 2023 23:17:51 +0000 Subject: [PATCH] Bug 33722: Make public lists viewable for users on virtualshelves/addbybiblionumber.pl To test: 1. Have two users with staff access and lists permissions. ( User A and User B) 2. Create some public lists with User A. Make some that are for staff only and some for everyone. 3. Make sure you create at least 10 different public lists. 4. Log in to the staff interface as user B and search the catalog. 5. Select a few titles and in the toolbar click 'Add to list'. 6. Here you should properly see your lists and any public lists which you can edit. 7. If you have more than 10 lists you won't see them all in this dropdown. 8. At the bottom of the dropdown you should see 'More lists', click it. 9. Notice here you cannot select any of the existing public lists which User B should be able to edit. 10. APPLY PATCH 11. Repeate steps 5 - 8. Now you should be able to edit public lists. 12. Create some private lists with User A and make sure User B cannot see them. 13. PLay with some new lists for User A and change 'Allow changes to contents from' and make sure User B can see the ones they should. --- .../virtualshelves/addbybiblionumber.tt | 21 +++------ virtualshelves/addbybiblionumber.pl | 44 +++++++------------ 2 files changed, 23 insertions(+), 42 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt index 51b9dde8e6..48cca158a1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt @@ -36,31 +36,24 @@ [% UNLESS ( shelfnumber ) %] [% UNLESS ( newshelf ) %] - [% IF private_shelves.count OR public_shelves.count OR private_shelves_shared_with_me.count %] + [% IF add_to_some_public_shelves.count OR add_to_some_private_shelves %]
Select an existing list