Bugzilla – Attachment 151730 Details for
Bug 32478
Remove Koha::Config::SysPref->find since bypasses cache
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32478: Fix syspref NULL values in tests
Bug-32478-Fix-syspref-NULL-values-in-tests.patch (text/plain), 1.82 KB, created by
Marcel de Rooy
on 2023-05-26 10:07:30 UTC
(
hide
)
Description:
Bug 32478: Fix syspref NULL values in tests
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-05-26 10:07:30 UTC
Size:
1.82 KB
patch
obsolete
>From b176450474a0036f0594a5cf9202eb421e665505 Mon Sep 17 00:00:00 2001 >From: David Gustafsson <david.gustafsson@ub.gu.se> >Date: Fri, 12 May 2023 16:52:33 +0200 >Subject: [PATCH] Bug 32478: Fix syspref NULL values in tests >Content-Type: text/plain; charset=utf-8 > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Koha/Item.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index 8b6abda059..6066c752bc 100755 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -2157,17 +2157,17 @@ subtest 'is_denied_renewal' => sub { > is( $deny_book->is_denied_renewal, 1, 'Renewal blocked when 3 rules matched (withdrawn, itype, location)' ); > is( $allow_book->is_denied_renewal, 0, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' ); > >- $idr_rules="itemcallnumber: [NULL]"; >+ $idr_rules="itemcallnumber: [null]"; > C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules); >- is( $deny_book->is_denied_renewal, 1, 'Renewal blocked for undef when NULL in pref' ); >+ is( $deny_book->is_denied_renewal, 1, 'Renewal blocked for undef when null in pref' ); > > $idr_rules="itemcallnumber: ['']"; > C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules); > is( $deny_book->is_denied_renewal, 0, 'Renewal not blocked for undef when "" in pref' ); > >- $idr_rules="itemnotes: [NULL]"; >+ $idr_rules="itemnotes: [null]"; > C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules); >- is( $deny_book->is_denied_renewal, 0, 'Renewal not blocked for "" when NULL in pref' ); >+ is( $deny_book->is_denied_renewal, 0, 'Renewal not blocked for "" when null in pref' ); > > $idr_rules="itemnotes: ['']"; > C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32478
:
144633
|
150685
|
150687
|
150688
|
150689
|
150690
|
151136
|
151726
|
151727
|
151728
|
151729
| 151730 |
151731
|
151732