From 42fe4410250fab413ac19181acb38540d5759d56 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 5 Jun 2023 13:53:18 -0300 Subject: [PATCH] Bug 21983: Add Koha::Biblio->ill_requests This patch adds a new method, used for retrieving the linked ill requests for a biblio. To test: 1. Apply this patch and run: $ ktd --shell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! --- Koha/Biblio.pm | 16 ++++++++++++++++ Koha/Schema/Result/Biblio.pm | 7 +++++++ t/db_dependent/Koha/Biblio.t | 28 +++++++++++++++++++++++++++- 3 files changed, 50 insertions(+), 1 deletion(-) diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm index 50d60c8a69e..3b697ec5362 100644 --- a/Koha/Biblio.pm +++ b/Koha/Biblio.pm @@ -39,6 +39,7 @@ use Koha::Cache::Memory::Lite; use Koha::Checkouts; use Koha::CirculationRules; use Koha::Exceptions; +use Koha::Illrequests; use Koha::Item::Transfer::Limits; use Koha::Items; use Koha::Libraries; @@ -164,6 +165,21 @@ sub tickets { return Koha::Tickets->_new_from_dbic( $rs ); } +=head3 ill_requests + + my $ill_requests = $biblio->ill_requests(); + +Returns a Koha::Illrequests object + +=cut + +sub ill_requests { + my ( $self ) = @_; + + my $ill_requests = $self->_result->ill_requests; + return Koha::Illrequests->_new_from_dbic($ill_requests); +} + =head3 item_groups my $item_groups = $biblio->item_groups(); diff --git a/Koha/Schema/Result/Biblio.pm b/Koha/Schema/Result/Biblio.pm index 42481e0ea20..24a2688caea 100644 --- a/Koha/Schema/Result/Biblio.pm +++ b/Koha/Schema/Result/Biblio.pm @@ -611,6 +611,13 @@ __PACKAGE__->has_many( { cascade_copy => 0, cascade_delete => 0 }, ); +__PACKAGE__->has_many( + "ill_requests", + "Koha::Schema::Result::Illrequest", + { "foreign.biblio_id" => "self.biblionumber" }, + { cascade_copy => 0, cascade_delete => 0 }, +); + __PACKAGE__->has_one( "metadata", "Koha::Schema::Result::BiblioMetadata", diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t index ef41c7636ad..9f8754aa91b 100755 --- a/t/db_dependent/Koha/Biblio.t +++ b/t/db_dependent/Koha/Biblio.t @@ -17,7 +17,7 @@ use Modern::Perl; -use Test::More tests => 23; # +1 +use Test::More tests => 24; use Test::Exception; use Test::Warn; @@ -1061,6 +1061,32 @@ subtest 'Recalls tests' => sub { $schema->storage->txn_rollback; }; +subtest 'ill_requests() tests' => sub { + + plan tests => 3; + + $schema->storage->txn_begin; + + my $biblio = $builder->build_sample_biblio; + + my $rs = $biblio->ill_requests; + is( ref($rs), 'Koha::Illrequests' ); + is( $rs->count, 0, 'No linked requests' ); + + foreach ( 1..10 ) { + $builder->build_object( + { + class => 'Koha::Illrequests', + value => { biblio_id => $biblio->id } + } + ); + } + + is( $biblio->ill_requests->count, 10, 'Linked requests are present' ); + + $schema->storage->txn_rollback; +}; + subtest 'item_groups() tests' => sub { plan tests => 6; -- 2.34.1