From 2d9b9e8ad2fbb0d38cd6b60215e94bc92d24224c Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 26 May 2023 12:54:22 +0000 Subject: [PATCH] Bug 33844: Modify test to show problem Add delete key. Without the follow-up, this triggers a delete. Test fails. DBIx::Class::Row::delete(): Not in database at /usr/share/koha/Koha/Object.pm line 234 Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens --- t/db_dependent/Koha/Item.t | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t index 6066c752bc..c22c782fe6 100755 --- a/t/db_dependent/Koha/Item.t +++ b/t/db_dependent/Koha/Item.t @@ -2143,7 +2143,8 @@ subtest 'is_denied_renewal' => sub { C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules); is( $deny_book->is_denied_renewal, 0, 'Renewal allowed when no rules' ); - $idr_rules="withdrawn: [1]"; + # The wrong column delete should be silently ignored and not trigger item delete + $idr_rules="delete: [yes]\nwithdrawn: [1]"; C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules); is( $deny_book->is_denied_renewal, 1, 'Renewal blocked when 1 rules (withdrawn)' ); is( $allow_book->is_denied_renewal, 0, 'Renewal allowed when 1 rules not matched (withdrawn)' ); -- 2.30.2