Bugzilla – Attachment 152471 Details for
Bug 33973
Sorting broken on ERM tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33973: Restore sorting on Vue tables
Bug-33973-Restore-sorting-on-Vue-tables.patch (text/plain), 1.60 KB, created by
Pedro Amorim
on 2023-06-19 10:15:26 UTC
(
hide
)
Description:
Bug 33973: Restore sorting on Vue tables
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-06-19 10:15:26 UTC
Size:
1.60 KB
patch
obsolete
>From f7e09c77fdf38d17af0bb2e4efa3a2cd819f668b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 9 Jun 2023 16:36:43 +0200 >Subject: [PATCH] Bug 33973: Restore sorting on Vue tables > >Regression from the KohaTable Vue component added by bug 33066. > >_dt_default_ajax expects options.columns to contain the columns. > >Test plan: >Add some agreements, go the the agreement list view and confirm that you >can now sort the agreements using the header columns. > >Note that the CSS is not correct yet. My understanding is that the >DataTable Vue component keep the 'sorting' class on the th which display >the grey up/down icon over the blue icon which indicate the current sort >column. > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue >index 6637980251..59376f00af 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/KohaTable.vue >@@ -44,7 +44,7 @@ export default { > ajax: { > url: typeof this.url === "function" ? this.url() : this.url, > ..._dt_default_ajax({ >- options: this.options, >+ options: { ...this.options, columns: this.columns }, > default_filters: this.default_filters, > }), > }, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33973
:
152254
|
152270
|
152471
|
152605